From: Chenbo Feng <chenbofeng.kernel@gmail.com>
To: "Bjørn Mork" <bjorn@mork.no>
Cc: David Miller <davem@davemloft.net>,
netdev@vger.kernel.org, lorenzo@google.com, edumazet@google.com,
fengc@google.com
Subject: Re: [PATCH net-next] ipv6: Initial skb->dev and skb->protocol in ip6_output
Date: Fri, 9 Jun 2017 12:45:01 -0700 [thread overview]
Message-ID: <9999fb16-74c0-1f7a-7657-5905fcc0db63@gmail.com> (raw)
In-Reply-To: <87d1adge1i.fsf@miraculix.mork.no>
On 06/09/2017 12:24 PM, Bjørn Mork wrote:
> Chenbo Feng <chenbofeng.kernel@gmail.com> writes:
>
>> This patch is still under working since it may have problem with
>> ip_fragment() call, did you applied it already? Should I send a revert
>> patch to you then?
> It does? I initially thought so too, but looking closer I believe the
> ip6_copy_metadata() calls in ip6_fragment() takes care of it.
>
>
>
> Bjørn
>
At least in the fail_toobig code path of ip_fragment() call, skb->dev
get assigned again. It seems to be redundant with this patch or it will
rewrite the skb->dev field. I will revert this one and upload again
after I have a proper handle for that.
next prev parent reply other threads:[~2017-06-09 19:45 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-06-09 19:06 [PATCH net-next] ipv6: Initial skb->dev and skb->protocol in ip6_output Chenbo Feng
2017-06-09 19:08 ` David Miller
2017-06-09 19:13 ` Chenbo Feng
2017-06-09 19:24 ` Bjørn Mork
2017-06-09 19:45 ` Chenbo Feng [this message]
2017-06-10 14:56 ` Eric Dumazet
2017-06-09 19:39 ` David Miller
2017-06-09 23:12 ` Chenbo Feng
2017-06-10 14:54 ` Eric Dumazet
[not found] ` <CAMOXUJnJ+e=f3x7gZsh4f=Fn01pspDqMKJFqc7cb7umV8SXtaw@mail.gmail.com>
2017-06-09 19:39 ` David Miller
2017-06-09 21:11 ` Eric Dumazet
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9999fb16-74c0-1f7a-7657-5905fcc0db63@gmail.com \
--to=chenbofeng.kernel@gmail.com \
--cc=bjorn@mork.no \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=fengc@google.com \
--cc=lorenzo@google.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox