From: Yanjun Zhu <yanjun.zhu@oracle.com>
To: David Miller <davem@davemloft.net>
Cc: netdev@vger.kernel.org, keescook@chromium.org
Subject: Re: [PATCH net-next 1/1] forcedeth: remove unnecessary variable
Date: Fri, 8 Dec 2017 10:11:08 +0800 [thread overview]
Message-ID: <999d84de-af50-10db-2b40-84247b4ecd7b@oracle.com> (raw)
In-Reply-To: <20171207.140719.544312559507472280.davem@davemloft.net>
On 2017/12/8 3:07, David Miller wrote:
> From: Zhu Yanjun <yanjun.zhu@oracle.com>
> Date: Wed, 6 Dec 2017 23:15:15 -0500
>
>> Since both tx_ring and first_tx are the head of tx ring, it not
>> necessary to use two variables. So first_tx is removed.
> These are not variables, they are structure members.
Sure. These 2 structure members are the head of tx ring. And they are
not changed in
the whole driver. So they are duplicate.
I will change to structure members and send V2.
Zhu Yanjun
>
next prev parent reply other threads:[~2017-12-08 2:10 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-12-07 4:15 [PATCH net-next 1/1] forcedeth: remove unnecessary variable Zhu Yanjun
2017-12-07 19:07 ` David Miller
2017-12-08 2:11 ` Yanjun Zhu [this message]
2017-12-10 3:07 ` [PATCHv2 net-next 1/1] forcedeth: remove unnecessary structure member Zhu Yanjun
2017-12-11 19:04 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=999d84de-af50-10db-2b40-84247b4ecd7b@oracle.com \
--to=yanjun.zhu@oracle.com \
--cc=davem@davemloft.net \
--cc=keescook@chromium.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).