From mboxrd@z Thu Jan 1 00:00:00 1970 From: Yanjun Zhu Subject: Re: [PATCH net-next 1/1] forcedeth: remove unnecessary variable Date: Fri, 8 Dec 2017 10:11:08 +0800 Message-ID: <999d84de-af50-10db-2b40-84247b4ecd7b@oracle.com> References: <1512620115-21544-1-git-send-email-yanjun.zhu@oracle.com> <20171207.140719.544312559507472280.davem@davemloft.net> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Cc: netdev@vger.kernel.org, keescook@chromium.org To: David Miller Return-path: Received: from aserp2130.oracle.com ([141.146.126.79]:51395 "EHLO aserp2130.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751020AbdLHCKV (ORCPT ); Thu, 7 Dec 2017 21:10:21 -0500 In-Reply-To: <20171207.140719.544312559507472280.davem@davemloft.net> Content-Language: en-US Sender: netdev-owner@vger.kernel.org List-ID: On 2017/12/8 3:07, David Miller wrote: > From: Zhu Yanjun > Date: Wed, 6 Dec 2017 23:15:15 -0500 > >> Since both tx_ring and first_tx are the head of tx ring, it not >> necessary to use two variables. So first_tx is removed. > These are not variables, they are structure members. Sure. These 2 structure members are the head of tx ring. And they are not changed in the whole driver. So they are duplicate. I will change to structure members and send V2. Zhu Yanjun >