Re: [PATCH net-next 2/8] dt-bindings: net: lan9645x: add LAN9645X switch bindings

[Jens Emil Schulz Ostergaard <jensemil.schulzostergaard@microchip.com>]

On Tue, 2026-03-03 at 15:22 +0200, Vladimir Oltean wrote:
> 
> On Tue, Mar 03, 2026 at 01:22:28PM +0100, Jens Emil Schulz Østergaard wrote:
> > +examples:
> > +  - |
> > +    soc {
> > +        #address-cells = <1>;
> > +        #size-cells = <0>;
> > +
> > +      ethernet-switch@0 {
> > +        reg = <0>;
> > +        compatible = "microchip,lan96459f-switch", "microchip,lan96455s-switch";
> > +        pinctrl-0 = <&lan9645x_leds>;
> > +        pinctrl-names = "default";
> > +
> > +        ethernet-ports {
> > +          #address-cells = <1>;
> > +          #size-cells = <0>;
> > +
> > +          port@0 {
> > +            reg = <0>;
> > +            label = "lan0";
> 
> Please remove labels from DSA examples. They do not constitute best
> practice, and it is preferable they don't leak into device trees by
> promoting them through binding examples.
> 
> It is currently recommended to name DSA (like other) network interfaces
> using udev rules set up by user space. Using labels is perhaps only
> tolerated for cases where the udev implementation is sub-par, like
> OpenWrt.

I will remove the labels in the next version.

Thanks,
Emil