From: Joey Lu <a0987203069@gmail.com>
To: Andrew Lunn <andrew@lunn.ch>
Cc: andrew+netdev@lunn.ch, davem@davemloft.net, edumazet@google.com,
kuba@kernel.org, pabeni@redhat.com, robh@kernel.org,
krzk+dt@kernel.org, conor+dt@kernel.org,
mcoquelin.stm32@gmail.com, richardcochran@gmail.com,
alexandre.torgue@foss.st.com, joabreu@synopsys.com,
ychuang3@nuvoton.com, schung@nuvoton.com, yclu4@nuvoton.com,
linux-arm-kernel@lists.infradead.org, netdev@vger.kernel.org,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
openbmc@lists.ozlabs.org,
linux-stm32@st-md-mailman.stormreply.com
Subject: Re: [PATCH 3/3] net: stmmac: dwmac-nuvoton: Add dwmac glue for Nuvoton MA35 family
Date: Thu, 7 Nov 2024 18:36:26 +0800 [thread overview]
Message-ID: <99fa8255-12b5-4a54-acfe-cc0fbbba9c0e@gmail.com> (raw)
In-Reply-To: <4c018927-b6ac-4414-9dde-487453350cca@lunn.ch>
Dear Andrew,
Thank you for your reply.
Andrew Lunn 於 11/7/2024 2:23 AM 寫道:
>> +struct nvt_priv_data {
>> + struct platform_device *pdev;
>> + int id;
>> + struct regmap *regmap;
>> + phy_interface_t phy_mode;
> phy_mode does not seem to be used outside of nuvoton_gmac_setup(). In
> fact nothing in nvt_priv_data is used outside of
> nuvoton_gmac_setup. So it looks like you can remove it.
I will remove it.
>> + if (of_property_read_u32(dev->of_node, "tx_delay", &tx_delay)) {
>> + dev_info(dev, "Set TX delay(0x0).\n");
>> + tx_delay = 0x0;
>> + } else {
>> + dev_info(dev, "Set TX delay(0x%x).\n", tx_delay);
> Please don't spam the logs. dev_dbg(), or no message at all.
>
> Andrew
I will fix it.
Thanks!
BR,
Joey
prev parent reply other threads:[~2024-11-07 10:36 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20241106111930.218825-1-a0987203069@gmail.com>
[not found] ` <20241106111930.218825-2-a0987203069@gmail.com>
[not found] ` <20241106-bloated-ranch-be94506d360c@spud>
2024-11-07 10:15 ` [PATCH 1/3] dt-bindings: net: nuvoton: Add schema for Nuvoton MA35 family GMAC Joey Lu
2024-11-07 11:47 ` Krzysztof Kozlowski
2024-11-07 17:09 ` Conor Dooley
2024-11-08 3:24 ` Joey Lu
[not found] ` <f3c6b67f-5c15-43e2-832e-28392fbe52ec@lunn.ch>
2024-11-07 10:31 ` Joey Lu
2024-11-07 13:18 ` Andrew Lunn
2024-11-11 9:17 ` Joey Lu
[not found] ` <12f4ea21-d83b-412c-9904-d9fe8f8a0167@lunn.ch>
2024-11-07 10:34 ` Joey Lu
[not found] ` <20241106111930.218825-4-a0987203069@gmail.com>
[not found] ` <4c018927-b6ac-4414-9dde-487453350cca@lunn.ch>
2024-11-07 10:36 ` Joey Lu [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=99fa8255-12b5-4a54-acfe-cc0fbbba9c0e@gmail.com \
--to=a0987203069@gmail.com \
--cc=alexandre.torgue@foss.st.com \
--cc=andrew+netdev@lunn.ch \
--cc=andrew@lunn.ch \
--cc=conor+dt@kernel.org \
--cc=davem@davemloft.net \
--cc=devicetree@vger.kernel.org \
--cc=edumazet@google.com \
--cc=joabreu@synopsys.com \
--cc=krzk+dt@kernel.org \
--cc=kuba@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-stm32@st-md-mailman.stormreply.com \
--cc=mcoquelin.stm32@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=openbmc@lists.ozlabs.org \
--cc=pabeni@redhat.com \
--cc=richardcochran@gmail.com \
--cc=robh@kernel.org \
--cc=schung@nuvoton.com \
--cc=ychuang3@nuvoton.com \
--cc=yclu4@nuvoton.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox