From: Florian Fainelli <f.fainelli@gmail.com>
To: Alexander Loktionov <Alexander.Loktionov@aquantia.com>,
netdev@vger.kernel.org, David VomLehn <vomlehn@texas.net>
Cc: "David S . Miller" <davem@davemloft.net>,
Simon Edelhaus <Simon.Edelhaus@aquantia.com>,
Dmitrii Tarakanov <Dmitrii.Tarakanov@aquantia.com>,
Pavel Belous <Pavel.Belous@aquantia.com>
Subject: Re: [PATCH v5 00/13] net: ethernet: aquantia: Add AQtion 2.5/5 GB NIC driver
Date: Fri, 13 Jan 2017 17:38:03 -0800 [thread overview]
Message-ID: <9a4e95cc-9daa-f883-46c0-f477e28b9f0f@gmail.com> (raw)
In-Reply-To: <cover.1484283610.git.vomlehn@texas.net>
On 01/12/2017 09:02 PM, Alexander Loktionov wrote:
> From: David VomLehn <vomlehn@texas.net>
>
> v1: Initial version
> v2: o Make necessary drivers/net/ethernet changes to integrate software
> o Drop intermediate atlantic directory
> o Remove Makefile things only appropriate to out of tree module
> building
> v3: o Move changes to drivers/net/ethernet/{Kconfig,Makefile} to the last
> patch to ensure clean bisection.
> o Removed inline attribute aq_hw_write_req() as it was defined in
> only one .c file.
> o #included pci.h in aq_common.h to get struct pci definition.
> o Modified code to unlock based execution flow rather than using a
> flag.
> o Made a number of functions that were only used in a single file
> static.
> o Cleaned up error and return code handling in various places.
> o Remove AQ_CFG_IP_ALIGN definition.
> o Other minor code clean up.
> v4: o Using do_div for 64 bit division.
> o Modified NIC statistics code.
> o Using build_skb instead netdev_alloc_skb for single fragment
> packets.
> o Removed extra aq_nic.o from Makefile
> v5: o Removed extra newline at the end of the files.
> o Wrapped cover letter lines.
Have not looked at the driver yet, but the threading of your emails is
weird, each patch is in reply to the previous one. It would be more
natural to have all numbered patches be in reply to the cover letter,
which according to the version of git you seem to have used (2.7.4)
should already be the default. In graphical terms what we see right now is:
[PATCH 00/13]
[PATCH 01/13]
[PATCH 02/13]
....
While we should see:
[PATCH 00/13]
[PATCH 01/13]
[PATCH 02/13]
....
Can you fix that for future submissions, this may sound like a cosmetic
thing, but it really helps with threading/reading etc.
Thanks!
--
Florian
next prev parent reply other threads:[~2017-01-14 1:38 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-01-13 5:02 [PATCH v5 00/13] net: ethernet: aquantia: Add AQtion 2.5/5 GB NIC driver Alexander Loktionov
2017-01-13 5:02 ` [PATCH v5 01/13] net: ethernet: aquantia: Make and configuration files Alexander Loktionov
2017-01-13 5:02 ` [PATCH v5 02/13] net: ethernet: aquantia: Common functions and definitions Alexander Loktionov
2017-01-13 5:02 ` [PATCH v5 03/13] net: ethernet: aquantia: Add ring support code Alexander Loktionov
2017-01-13 5:02 ` [PATCH v5 04/13] net: ethernet: aquantia: Low-level hardware interfaces Alexander Loktionov
2017-01-13 5:02 ` [PATCH v5 05/13] net: ethernet: aquantia: Support for NIC-specific code Alexander Loktionov
2017-01-13 5:02 ` [PATCH v5 06/13] net: ethernet: aquantia: Atlantic A0 and B0 specific functions Alexander Loktionov
2017-01-13 5:02 ` [PATCH v5 07/13] net: ethernet: aquantia: Vector operations Alexander Loktionov
2017-01-13 5:02 ` [PATCH v5 08/13] net: ethernet: aquantia: PCI operations Alexander Loktionov
2017-01-13 5:02 ` [PATCH v5 09/13] net: ethernet: aquantia: Atlantic hardware abstraction layer Alexander Loktionov
2017-01-13 5:02 ` [PATCH v5 10/13] net: ethernet: aquantia: Hardware interface and utility functions Alexander Loktionov
2017-01-13 5:02 ` [PATCH v5 11/13] net: ethernet: aquantia: Ethtool support Alexander Loktionov
2017-01-13 5:02 ` [PATCH v5 12/13] net: ethernet: aquantia: Receive side scaling Alexander Loktionov
2017-01-13 5:02 ` [PATCH v5 13/13] net: ethernet: aquantia: Integrate AQtion 2.5/5 GB NIC driver Alexander Loktionov
2017-01-14 1:47 ` [PATCH v5 11/13] net: ethernet: aquantia: Ethtool support Florian Fainelli
2017-01-14 1:48 ` [PATCH v5 08/13] net: ethernet: aquantia: PCI operations Florian Fainelli
2017-01-14 2:00 ` [PATCH v5 05/13] net: ethernet: aquantia: Support for NIC-specific code Florian Fainelli
2017-01-14 22:55 ` Rami Rosen
2017-01-15 1:15 ` Andrew Lunn
2017-01-14 1:32 ` [PATCH v5 02/13] net: ethernet: aquantia: Common functions and definitions David Miller
2017-01-13 5:06 ` [PATCH v5 01/13] net: ethernet: aquantia: Make and configuration files Joe Perches
2017-01-13 5:24 ` David VomLehn
2017-01-13 5:59 ` Joe Perches
2017-01-13 6:57 ` David VomLehn
2017-01-13 7:28 ` Joe Perches
2017-01-14 2:01 ` Florian Fainelli
2017-01-14 18:39 ` Florian Fainelli
2017-01-14 18:42 ` David VomLehn
2017-01-14 18:48 ` Florian Fainelli
2017-01-14 19:04 ` David VomLehn
2017-01-14 1:38 ` Florian Fainelli [this message]
2017-01-14 3:41 ` [PATCH v5 00/13] net: ethernet: aquantia: Add AQtion 2.5/5 GB NIC driver David VomLehn
2017-01-14 2:05 ` Florian Fainelli
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9a4e95cc-9daa-f883-46c0-f477e28b9f0f@gmail.com \
--to=f.fainelli@gmail.com \
--cc=Alexander.Loktionov@aquantia.com \
--cc=Dmitrii.Tarakanov@aquantia.com \
--cc=Pavel.Belous@aquantia.com \
--cc=Simon.Edelhaus@aquantia.com \
--cc=davem@davemloft.net \
--cc=netdev@vger.kernel.org \
--cc=vomlehn@texas.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).