Netdev List
 help / color / mirror / Atom feed
From: Paolo Abeni <pabeni@redhat.com>
To: Bochao Cao <bochaolucky@gmail.com>,
	Daniel Borkmann <daniel@iogearbox.net>,
	Jakub Kicinski <kuba@kernel.org>
Cc: "Alexis Lothoré" <alexis.lothore@bootlin.com>,
	"Emil Tsalapatis" <emil@etsalapatis.com>,
	"Lorenzo Bianconi" <lorenzo@kernel.org>,
	"Shuah Khan" <shuah@kernel.org>,
	bpf@vger.kernel.org, netdev@vger.kernel.org,
	linux-kselftest@vger.kernel.org
Subject: Re: [PATCH net-next v3] selftests/bpf: Track test_xdp_features DUT processes
Date: Thu, 10 Sep 2026 11:47:57 +0200	[thread overview]
Message-ID: <9a4f9408-bcf8-430f-adc8-f69c771f333b@redhat.com> (raw)
In-Reply-To: <20260904-xdp-dut-process-lifecycle-gmail-v3-1-5b7eee4f7009@gmail.com>

On 9/4/26 6:44 AM, Bochao Cao wrote:
> test_xdp_features.sh waits for any xdp_features listener to appear and
> uses pidof during cleanup. A concurrent test can therefore make another
> test proceed before its own DUT is ready, and cleanup kills every
> xdp_features process on the host. The readiness loop also has no timeout,
> so a DUT that exits before listening leaves the test hung indefinitely.
> 
> Track one active DUT at a time, wait for ss to report that exact PID with
> a bounded retry loop, and reap it after each test. Consult the shell job
> table before signaling the DUT so a stale PID cannot target an unrelated
> process. On failure, terminate the shell job with SIGKILL and reap it so
> blocked I/O cannot hang cleanup. Install an EXIT trap and signal handlers
> so failure paths also remove network setup.
> 
> Fixes: 4dba3e7852b7 ("selftests/bpf: introduce XDP compliance test tool")
> Signed-off-by: Bochao Cao <bochaolucky@gmail.com>
> Reviewed-by: Emil Tsalapatis <emil@etsalapatis.com>
Since the goal of targeting net-next is allowing shorted turn-over for
the conversion to driver/hw, I think it would be better to include the
latter change in the same series.

Also it would be possibly make sense to take care of the last sashiko
comment (about signal handling).

/P


      parent reply	other threads:[~2026-09-10  9:48 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-09-04  4:44 [PATCH net-next v3] selftests/bpf: Track test_xdp_features DUT processes Bochao Cao via B4 Relay
2026-09-09  7:46 ` netdev-bot+sashiko
2026-09-10  9:47 ` Paolo Abeni [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=9a4f9408-bcf8-430f-adc8-f69c771f333b@redhat.com \
    --to=pabeni@redhat.com \
    --cc=alexis.lothore@bootlin.com \
    --cc=bochaolucky@gmail.com \
    --cc=bpf@vger.kernel.org \
    --cc=daniel@iogearbox.net \
    --cc=emil@etsalapatis.com \
    --cc=kuba@kernel.org \
    --cc=linux-kselftest@vger.kernel.org \
    --cc=lorenzo@kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=shuah@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox