From mboxrd@z Thu Jan 1 00:00:00 1970 From: Sergei Shtylyov Subject: Re: [PATCH net-next] ravb: Disable Pause Advertisement Date: Fri, 21 Sep 2018 20:25:57 +0300 Message-ID: <9a6fd74a-7e2b-afa7-22ac-d85d5730a0af@cogentembedded.com> References: <1537537946-24786-1-git-send-email-andrew@lunn.ch> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Cc: Simon Horman , Florian Fainelli , netdev To: Andrew Lunn , David Miller Return-path: Received: from mail-lj1-f179.google.com ([209.85.208.179]:34712 "EHLO mail-lj1-f179.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2390076AbeIUXPx (ORCPT ); Fri, 21 Sep 2018 19:15:53 -0400 Received: by mail-lj1-f179.google.com with SMTP id f8-v6so12365686ljk.1 for ; Fri, 21 Sep 2018 10:26:01 -0700 (PDT) In-Reply-To: <1537537946-24786-1-git-send-email-andrew@lunn.ch> Content-Language: en-MW Sender: netdev-owner@vger.kernel.org List-ID: Hello! You forgot to CC me. :-/ On 09/21/2018 04:52 PM, Andrew Lunn wrote: > The previous commit to ravb had the side effect of making the PHY > advertise Pause and Asym Pause, which previously did not happen. By > default, phydev->supported has both forms of pause enabled, but > phydev->advertising does not. The new phy_remove_link_mode() copies > phydev->supported to phydev->advertising after removing the requested > link mode. These Pause configuration bits appears it stops the PHY > from completing Auto-Neg and the link remains down. Be explicit and > remove the Pause and Asym Pause modes, so restoring the old behavior. > > Reported-by: Simon Horman > Fixes: 41124fa64d4b ("net: ethernet: Add helper to remove a supported link mode") > Signed-off-by: Andrew Lunn [...] Reviewed-by: Sergei Shtylyov MBR, Sergei