netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Jesper Juhl <jesper.juhl@gmail.com>
To: Sridhar Samudrala <sri@us.ibm.com>
Cc: Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
	Alexey Dobriyan <adobriyan@mail.ru>,
	Herbert Xu <herbert@gondor.apana.org.au>,
	YOSHIFUJI Hideaki <yoshfuji@linux-ipv6.org>,
	"David S. Miller" <davem@davemloft.net>,
	Benjamin Reed <breed@users.sourceforge.net>,
	Andy Adamson <andros@citi.umich.edu>,
	netdev@vger.kernel.org,
	lksctp developers <lksctp-developers@lists.sourceforge.net>,
	Bruce Fields <bfields@umich.edu>, Andy Adamson <andros@umich.edu>,
	linux-net@vger.kernel.org, linux-crypto@vger.kernel.org
Subject: Re: [PATCH] crypto_free_tfm callers do not need to check for NULL
Date: Tue, 30 Aug 2005 23:26:50 +0200	[thread overview]
Message-ID: <9a87484905083014267caba221@mail.gmail.com> (raw)
In-Reply-To: <1125436415.3952.11.camel@w-sridhar2.beaverton.ibm.com>

On 8/30/05, Sridhar Samudrala <sri@us.ibm.com> wrote:
> On Tue, 2005-08-30 at 22:45 +0200, Jesper Juhl wrote:
> > Since the patch to add a NULL short-circuit to crypto_free_tfm() went in,
> > there's no longer any need for callers of that function to check for NULL.
> > This patch removes the redundant NULL checks and also a few similar checks
> > for NULL before calls to kfree() that I ran into while doing the
> > crypto_free_tfm bits.
> >
> > I've posted similar patches in the past, but was asked to first until the
> > short-circuit patch moved from -mm to mainline - and since it is now
> > firmly there in 2.6.13 I assume there's no problem there anymore.
> > I was also asked previously to make the patch against mainline and not -mm,
> > so this patch is against 2.6.13.
> >
> > Feedback, ACK, NACK, etc welcome.
> 
> sctp change looks fine.
> A similar check in sctp_endpoint_destroy() can also be removed.
> 
Thanks, I'll remember that and either update the patch or send a small
incremental one later.

-- 
Jesper Juhl <jesper.juhl@gmail.com>
Don't top-post  http://www.catb.org/~esr/jargon/html/T/top-post.html
Plain text mails only, please      http://www.expita.com/nomime.html

  reply	other threads:[~2005-08-30 21:26 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2005-08-30 20:45 [PATCH] crypto_free_tfm callers do not need to check for NULL Jesper Juhl
2005-08-30 20:49 ` J. Bruce Fields
2005-08-30 21:13 ` Sridhar Samudrala
2005-08-30 21:26   ` Jesper Juhl [this message]
2005-08-31 11:57 ` Herbert Xu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=9a87484905083014267caba221@mail.gmail.com \
    --to=jesper.juhl@gmail.com \
    --cc=adobriyan@mail.ru \
    --cc=andros@citi.umich.edu \
    --cc=andros@umich.edu \
    --cc=bfields@umich.edu \
    --cc=breed@users.sourceforge.net \
    --cc=davem@davemloft.net \
    --cc=herbert@gondor.apana.org.au \
    --cc=linux-crypto@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-net@vger.kernel.org \
    --cc=lksctp-developers@lists.sourceforge.net \
    --cc=netdev@vger.kernel.org \
    --cc=sri@us.ibm.com \
    --cc=yoshfuji@linux-ipv6.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).