From: Florian Fainelli <f.fainelli@gmail.com>
To: John Crispin <john@phrozen.org>, "David S. Miller" <davem@davemloft.net>
Cc: netdev@vger.kernel.org
Subject: Re: [PATCH] net-next: korina: Fix NAPI versus resources freeing
Date: Wed, 4 Jan 2017 06:24:52 -0800 [thread overview]
Message-ID: <9a88ebba-f48b-b3a3-5aee-eec0d6aa6548@gmail.com> (raw)
In-Reply-To: <1483522278-36891-1-git-send-email-john@phrozen.org>
On 01/04/2017 01:31 AM, John Crispin wrote:
> From: Florian Fainelli <f.fainelli@gmail.com>
>
> Commit beb0babfb77e ("korina: disable napi on close and restart")
> introduced calls to napi_disable() that were missing before,
> unfortunately this leaves a small window during which NAPI has a chance
> to run, yet we just freed resources since korina_free_ring() has been
> called:
>
> Fix this by disabling NAPI first then freeing resource, and make sure
> that we also cancel the restart taks before doing the resource freeing.
>
> Fixes: beb0babfb77e ("korina: disable napi on close and restart")
I submitted this patch to 'net' already, but thanks for doing it!
--
Florian
prev parent reply other threads:[~2017-01-04 14:26 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-01-04 9:31 [PATCH] net-next: korina: Fix NAPI versus resources freeing John Crispin
2017-01-04 14:24 ` Florian Fainelli [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9a88ebba-f48b-b3a3-5aee-eec0d6aa6548@gmail.com \
--to=f.fainelli@gmail.com \
--cc=davem@davemloft.net \
--cc=john@phrozen.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox