From: David Ahern <dsahern@kernel.org>
To: Ido Schimmel <idosch@nvidia.com>, netdev@vger.kernel.org
Cc: davem@davemloft.net, kuba@kernel.org, pabeni@redhat.com,
edumazet@google.com, horms@kernel.org, willemb@google.com
Subject: Re: [PATCH net-next v3 3/3] selftests: fib_tests: Add test cases for route lookup with oif
Date: Thu, 11 Jun 2026 12:28:24 -0600 [thread overview]
Message-ID: <9a9a8e6b-db0d-4e7c-8256-4ef31136377a@kernel.org> (raw)
In-Reply-To: <20260611154605.992528-4-idosch@nvidia.com>
On 6/11/26 9:46 AM, Ido Schimmel wrote:
> Test that both address families respect the oif parameter when a
> matching multipath route is found, regardless of the presence of a
> source address.
>
> Output without "ipv6: Select best matching nexthop object in
> fib6_table_lookup()" and "ipv6: Honor oif when choosing nexthop for
> locally generated traffic":
>
> # ./fib_tests.sh -t "ipv4_mpath_oif ipv4_mpath_oif_nh ipv4_mpath_oif_vrf ipv6_mpath_oif ipv6_mpath_oif_nh ipv6_mpath_oif_vrf"
>
> IPv4 multipath oif test
> TEST: IPv4 multipath via first nexthop [ OK ]
> TEST: IPv4 multipath via second nexthop [ OK ]
> TEST: IPv4 multipath via first nexthop with source address [ OK ]
> TEST: IPv4 multipath via second nexthop with source address [ OK ]
>
> IPv4 multipath oif with nexthop object test
> TEST: IPv4 multipath via first nexthop [ OK ]
> TEST: IPv4 multipath via second nexthop [ OK ]
> TEST: IPv4 multipath via first nexthop with source address [ OK ]
> TEST: IPv4 multipath via second nexthop with source address [ OK ]
>
> IPv4 multipath oif with VRF test
> TEST: IPv4 multipath via first nexthop [ OK ]
> TEST: IPv4 multipath via second nexthop [ OK ]
> TEST: IPv4 multipath via first nexthop with source address [ OK ]
> TEST: IPv4 multipath via second nexthop with source address [ OK ]
>
> IPv6 multipath oif test
> TEST: IPv6 multipath via first nexthop [ OK ]
> TEST: IPv6 multipath via second nexthop [ OK ]
> TEST: IPv6 multipath via first nexthop with source address [FAIL]
> TEST: IPv6 multipath via second nexthop with source address [FAIL]
>
> IPv6 multipath oif with nexthop object test
> TEST: IPv6 multipath via first nexthop [FAIL]
> TEST: IPv6 multipath via second nexthop [FAIL]
> TEST: IPv6 multipath via first nexthop with source address [FAIL]
> TEST: IPv6 multipath via second nexthop with source address [FAIL]
>
> IPv6 multipath oif with VRF test
> TEST: IPv6 multipath via first nexthop [ OK ]
> TEST: IPv6 multipath via second nexthop [ OK ]
> TEST: IPv6 multipath via first nexthop with source address [FAIL]
> TEST: IPv6 multipath via second nexthop with source address [FAIL]
>
> Tests passed: 16
> Tests failed: 8
>
> Output with the patches:
>
> # ./fib_tests.sh -t "ipv4_mpath_oif ipv4_mpath_oif_nh ipv4_mpath_oif_vrf ipv6_mpath_oif ipv6_mpath_oif_nh ipv6_mpath_oif_vrf"
>
> IPv4 multipath oif test
> TEST: IPv4 multipath via first nexthop [ OK ]
> TEST: IPv4 multipath via second nexthop [ OK ]
> TEST: IPv4 multipath via first nexthop with source address [ OK ]
> TEST: IPv4 multipath via second nexthop with source address [ OK ]
>
> IPv4 multipath oif with nexthop object test
> TEST: IPv4 multipath via first nexthop [ OK ]
> TEST: IPv4 multipath via second nexthop [ OK ]
> TEST: IPv4 multipath via first nexthop with source address [ OK ]
> TEST: IPv4 multipath via second nexthop with source address [ OK ]
>
> IPv4 multipath oif with VRF test
> TEST: IPv4 multipath via first nexthop [ OK ]
> TEST: IPv4 multipath via second nexthop [ OK ]
> TEST: IPv4 multipath via first nexthop with source address [ OK ]
> TEST: IPv4 multipath via second nexthop with source address [ OK ]
>
> IPv6 multipath oif test
> TEST: IPv6 multipath via first nexthop [ OK ]
> TEST: IPv6 multipath via second nexthop [ OK ]
> TEST: IPv6 multipath via first nexthop with source address [ OK ]
> TEST: IPv6 multipath via second nexthop with source address [ OK ]
>
> IPv6 multipath oif with nexthop object test
> TEST: IPv6 multipath via first nexthop [ OK ]
> TEST: IPv6 multipath via second nexthop [ OK ]
> TEST: IPv6 multipath via first nexthop with source address [ OK ]
> TEST: IPv6 multipath via second nexthop with source address [ OK ]
>
> IPv6 multipath oif with VRF test
> TEST: IPv6 multipath via first nexthop [ OK ]
> TEST: IPv6 multipath via second nexthop [ OK ]
> TEST: IPv6 multipath via first nexthop with source address [ OK ]
> TEST: IPv6 multipath via second nexthop with source address [ OK ]
>
> Tests passed: 24
> Tests failed: 0
>
> Signed-off-by: Ido Schimmel <idosch@nvidia.com>
> ---
> tools/testing/selftests/net/fib_tests.sh | 251 ++++++++++++++++++++++-
> 1 file changed, 250 insertions(+), 1 deletion(-)
>
Reviewed-by: David Ahern <dsahern@kernel.org>
prev parent reply other threads:[~2026-06-11 18:28 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-06-11 15:46 [PATCH net-next v3 0/3] ipv6: Honor oif when choosing nexthop for locally generated traffic Ido Schimmel
2026-06-11 15:46 ` [PATCH net-next v3 1/3] ipv6: Select best matching nexthop object in fib6_table_lookup() Ido Schimmel
2026-06-11 18:25 ` David Ahern
2026-06-11 15:46 ` [PATCH net-next v3 2/3] ipv6: Honor oif when choosing nexthop for locally generated traffic Ido Schimmel
2026-06-11 15:46 ` [PATCH net-next v3 3/3] selftests: fib_tests: Add test cases for route lookup with oif Ido Schimmel
2026-06-11 18:28 ` David Ahern [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9a9a8e6b-db0d-4e7c-8256-4ef31136377a@kernel.org \
--to=dsahern@kernel.org \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=horms@kernel.org \
--cc=idosch@nvidia.com \
--cc=kuba@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=willemb@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox