netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Mor Bar-Gabay <morx.bar.gabay@intel.com>
To: "Markus Blöchl" <markus@blochl.de>,
	"Tony Nguyen" <anthony.l.nguyen@intel.com>,
	"Przemek Kitszel" <przemyslaw.kitszel@intel.com>,
	"Richard Cochran" <richardcochran@gmail.com>,
	"Thomas Gleixner" <tglx@linutronix.de>
Cc: Lakshmi Sowjanya D <lakshmi.sowjanya.d@intel.com>,
	Andrew Lunn <andrew+netdev@lunn.ch>,
	"David S. Miller" <davem@davemloft.net>,
	"Eric Dumazet" <edumazet@google.com>,
	Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
	<markus.bloechl@ipetronik.com>, John Stultz <jstultz@google.com>,
	<intel-wired-lan@lists.osuosl.org>, <netdev@vger.kernel.org>,
	<linux-kernel@vger.kernel.org>
Subject: Re: [Intel-wired-lan] [PATCH v2] e1000e: Populate entire system_counterval_t in get_time_fn() callback
Date: Thu, 17 Jul 2025 12:58:06 +0300	[thread overview]
Message-ID: <9abe0c53-93bd-4037-bc5e-a6888a0dcc2d@intel.com> (raw)
In-Reply-To: <20250709-e1000e_crossts-v2-1-2aae94384c59@blochl.de>

On 09/07/2025 20:28, Markus Blöchl wrote:
> get_time_fn() callback implementations are expected to fill out the
> entire system_counterval_t struct as it may be initially uninitialized.
> 
> This broke with the removal of convert_art_to_tsc() helper functions
> which left use_nsecs uninitialized.
> 
> Assign the entire struct again.
> 
> Fixes: bd48b50be50a ("e1000e: Replace convert_art_to_tsc()")
> Cc: stable@vger.kernel.org
> Signed-off-by: Markus Blöchl <markus@blochl.de>
> Reviewed-by: Aleksandr Loktionov <aleksandr.loktionov@intel.com>
> Reviewed-by: Simon Horman <horms@kernel.org>
> Reviewed-by: Aleksandr Loktionov <aleksandr.loktionov@intel.com>
> Reviewed-by: Vitaly Lifshits <vitaly.lifshits@intel.com>
> ---
> Notes:
>      Related-To: <https://lore.kernel.org/lkml/txyrr26hxe3xpq3ebqb5ewkgvhvp7xalotaouwludjtjifnah2@7tmgczln4aoo/>
> 
> Changes in v2:
> - Add Lakshmi in Cc:
> - Add Signed-off-by: trailer which was lost in b4 workflow
> - Link to v1: https://lore.kernel.org/r/20250709-e1000e_crossts-v1-1-f8a80c792e4f@blochl.de
> ---
>   drivers/net/ethernet/intel/e1000e/ptp.c | 7 +++++--
>   1 file changed, 5 insertions(+), 2 deletions(-)
> 
Tested-by: Mor Bar-Gabay <morx.bar.gabay@intel.com>

      parent reply	other threads:[~2025-07-17  9:58 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-07-09 17:28 [PATCH v2] e1000e: Populate entire system_counterval_t in get_time_fn() callback Markus Blöchl
2025-07-09 18:03 ` [Intel-wired-lan] " Loktionov, Aleksandr
2025-07-10 10:25 ` Simon Horman
2025-07-10 10:33   ` [Intel-wired-lan] " Loktionov, Aleksandr
2025-07-13 10:41     ` Lifshits, Vitaly
2025-07-17  9:58 ` Mor Bar-Gabay [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=9abe0c53-93bd-4037-bc5e-a6888a0dcc2d@intel.com \
    --to=morx.bar.gabay@intel.com \
    --cc=andrew+netdev@lunn.ch \
    --cc=anthony.l.nguyen@intel.com \
    --cc=davem@davemloft.net \
    --cc=edumazet@google.com \
    --cc=intel-wired-lan@lists.osuosl.org \
    --cc=jstultz@google.com \
    --cc=kuba@kernel.org \
    --cc=lakshmi.sowjanya.d@intel.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=markus.bloechl@ipetronik.com \
    --cc=markus@blochl.de \
    --cc=netdev@vger.kernel.org \
    --cc=pabeni@redhat.com \
    --cc=przemyslaw.kitszel@intel.com \
    --cc=richardcochran@gmail.com \
    --cc=tglx@linutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).