From mboxrd@z Thu Jan  1 00:00:00 1970
From: Ed Swierk <eswierk@aristanetworks.com>
Subject: Re: [Regression in 2.6.29] forcedeth doesn't work after resume from
	hibernation (was: Re: Resume after hibernation regression in 2.6.29)
Date: Fri, 3 Apr 2009 08:24:12 -0700
Message-ID: <9ae48b020904030824o1f94831asb60f979b3e489a8b@mail.gmail.com>
References: <200903261920.32173.tvrtko@ursulin.net>
	 <200903270801.46712.tvrtko@ursulin.net>
	 <200903271255.36429.rjw@sisk.pl> <200903272109.21259.rjw@sisk.pl>
Mime-Version: 1.0
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: QUOTED-PRINTABLE
Cc: "Tvrtko A. Ursulin" <tvrtko@ursulin.net>,
	Pavel Machek <pavel@ucw.cz>,
	linux-pm <linux-pm@lists.linux-foundation.org>,
	kernel list <linux-kernel@vger.kernel.org>,
	Tobias Diedrich <ranma+kernel@tdiedrich.de>,
	Ayaz Abdulla <aabdulla@nvidia.com>,
	netdev <netdev@vger.kernel.org>,
	Arthur Jones <ajones@riverbed.com>,
	Andrew Morton <akpm@linux-foundation.org>,
	"David S. Miller" <davem@davemloft.net>
To: "Rafael J. Wysocki" <rjw@sisk.pl>
Return-path: <netdev-owner@vger.kernel.org>
Received: from mail-qy0-f118.google.com ([209.85.221.118]:52687 "EHLO
	mail-qy0-f118.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1755646AbZDCPbO convert rfc822-to-8bit (ORCPT
	<rfc822;netdev@vger.kernel.org>); Fri, 3 Apr 2009 11:31:14 -0400
In-Reply-To: <200903272109.21259.rjw@sisk.pl>
Sender: netdev-owner@vger.kernel.org
List-ID: <netdev.vger.kernel.org>

On Fri, Mar 27, 2009 at 1:09 PM, Rafael J. Wysocki <rjw@sisk.pl> wrote:
> I was able to reproduce the problem and identify the commit that brok=
e the
> resume of forcedeth, which turned out to be:
>
> commit cb52deba12f27af90a46d2f8667a64888118a888
> Author: Ed Swierk <eswierk@arastra.com>
> Date: =A0 Mon Dec 1 12:24:43 2008 +0000
>
> =A0 =A0forcedeth: power down phy when interface is down
>
> =A0 =A0Signed-off-by: Ed Swierk <eswierk@arastra.com>
> =A0 =A0Tested-by: Arthur Jones <ajones@riverbed.com>
> =A0 =A0Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
> =A0 =A0Signed-off-by: David S. Miller <davem@davemloft.net>
>
> Since I have no slightest idea of what this commit is supposed to ach=
ieve,
> I can only ask for reverting it. =A0It reverts cleanly, BTW.

The change causes forcedeth to bring down the physical link when an
interface goes down; leaving it up causes the switch at the other end
to think the port is still active, with potentially random speed and
duplex parameters.

It's possible that the forcedeth driver needs to reset autonegotiation
after bringing it up the link again.

Can you please try this on a 2.6.29 kernel that's exhibiting the
symptoms you describe, after resuming the machine from hibernation:

  ethtool -s eth1 autoneg off speed 100 duplex full
  ethtool -s eth1 autoneg on

This should reset autonegotiation manually and bring the link. Let me
know how it goes.

Thanks,
--Ed