netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Eric Dumazet <eric.dumazet@gmail.com>
To: Captain Wiggum <captwiggum@gmail.com>,
	Eric Dumazet <eric.dumazet@gmail.com>,
	Florian Westphal <fw@strlen.de>
Cc: David Miller <davem@davemloft.net>,
	netdev@vger.kernel.org, Peter Oskolkov <posk@google.com>
Subject: Re: TAHI testing fails for IPv6 Fragments in Kernel 4.9
Date: Mon, 11 Mar 2019 21:20:25 -0700	[thread overview]
Message-ID: <9aec5c97-a488-8b75-60e9-ff9c198c636b@gmail.com> (raw)
In-Reply-To: <CAB=W+o=-30-FPcLR-_vpdJaKFiTObNUwsCfPErhjVoq7i9Unxg@mail.gmail.com>



On 03/11/2019 09:12 PM, Captain Wiggum wrote:
> Hi All,
> 
> To summarize this thread, we test for IPv6 Ready Logo using Self-test
> Tools (TAHI Project) here:
> https://www.ipv6ready.org/?page=documents&tag=ipv6-core-protocols
> 
> 4.9.133 and previous passed 100%. Beginning with 4.9.134 it fails 18
> tests related to IPv6 fragment headers.
> I have done a git bisect, built and tested 7 revisions between 4.9.133
> - 4.9.134, this is the final bisect result:
> ------
> $ git bisect bad
> a8444b1ccb20339774af58e40ad42296074fb484 is the first bad commit
> commit a8444b1ccb20339774af58e40ad42296074fb484
> Author: Florian Westphal <fw@strlen.de>
> Date:   Wed Oct 10 12:30:10 2018 -0700
> ipv6: defrag: drop non-last frags smaller than min mtu
> ------
> Also I believe it fails in all kernels since then, 4.19, stable, etc.
> Would it be possible for someone to look at that?
> Any tips appreciated.
> 
> --John Masinter
> 

Hi John

Yes, this is basically what I answered last week about this problem,
there was no need for a bisection :/

This has been solved in upstream kernels with this patch, not yet backported to v4.9.xxx

d4289fcc9b16b89619ee1c54f829e05e56de8b9a net: IP6 defrag: use rbtrees for IPv6 defrag


  parent reply	other threads:[~2019-03-12  4:20 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-03-06 22:26 TAHI testing fails for IPv6 Fragments in Kernel 4.9 Captain Wiggum
2019-03-06 22:28 ` David Miller
2019-03-06 22:34   ` Eric Dumazet
2019-03-06 22:50     ` David Miller
2019-03-06 22:51     ` Captain Wiggum
2019-03-12  4:12       ` Captain Wiggum
2019-03-12  4:18         ` Captain Wiggum
2019-03-12  4:20         ` Eric Dumazet [this message]
2019-03-12  4:29           ` Captain Wiggum
2019-03-06 22:29 ` Florian Fainelli

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=9aec5c97-a488-8b75-60e9-ff9c198c636b@gmail.com \
    --to=eric.dumazet@gmail.com \
    --cc=captwiggum@gmail.com \
    --cc=davem@davemloft.net \
    --cc=fw@strlen.de \
    --cc=netdev@vger.kernel.org \
    --cc=posk@google.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).