From: Antonio Quartulli <antonio@mandelbit.com>
To: Willem de Bruijn <willemdebruijn.kernel@gmail.com>, jasowangio@gmail.com
Cc: andrew+netdev@lunn.ch, davem@davemloft.net, edumazet@kernel.org,
kuba@kernel.org, pabeni@redhat.com, horms@kernel.org,
mst@redhat.com, eperezma@redhat.com, shuah@kernel.org,
ast@kernel.org, daniel@iogearbox.net, hawk@kernel.org,
john.fastabend@gmail.com, sdf@fomichev.me, maheshb@google.com,
peterpenkov96@gmail.com, netdev@vger.kernel.org,
virtualization@lists.linux.dev, linux-kselftest@vger.kernel.org,
bpf@vger.kernel.org
Subject: Re: [PATCH net v5 2/2] selftests: net: add a vhost-net test for the tun NAPI queue bound
Date: Fri, 13 Nov 2026 16:19:32 +0100 [thread overview]
Message-ID: <9afd9031-9a66-4c13-b1a2-e1da62ef5e69@mandelbit.com> (raw)
In-Reply-To: <willemdebruijn.kernel.14b320acee076@gmail.com>
On 13/11/2026 16:07, Willem de Bruijn wrote:
>>> That's a lot of code for a fairly narrow test.
>>>
>>> Not that long ago I would have applauded all test coverage we can get.
>>> But now that LLMs generate them instantly, not sure where to draw the
>>> line.
>>
>> Well, the test has already done its job because it immediately helped me
>> fix some small itches in patch 1.
>>
>> This said, I can definitely shrink this test a bit, maybe around 50% of
>> the current code. But it'll still be quite some code for a small fix.
>>
>> Should I just drop this patch?
>>
>> Alternatively, I drop it from this series and I send the shrunk-down
>> version with the wrapper script to net-next later on.
>>
>>
>> Opinions?
>
> If you could compress it to about 50%, let's merge.
>
> Maybe we can use it over time for more coverage in this area.
Ok, I'll see what I can do and I'll send v6 including a compressed test.
Regards,
--
Antonio Quartulli
CEO and Co-Founder
Mandelbit Srl
https://www.mandelbit.com
prev parent reply other threads:[~2026-11-13 15:19 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-11 1:42 [PATCH net v5 0/2] tun: bound the NAPI receive queue Antonio Quartulli
2026-11-11 1:42 ` [PATCH net v5 1/2] " Antonio Quartulli
2026-11-12 23:28 ` Willem de Bruijn
2026-11-13 0:29 ` Antonio Quartulli
2026-11-11 1:42 ` [PATCH net v5 2/2] selftests: net: add a vhost-net test for the tun NAPI queue bound Antonio Quartulli
2026-11-12 23:34 ` Willem de Bruijn
2026-11-13 0:33 ` Antonio Quartulli
2026-11-13 15:07 ` Willem de Bruijn
2026-11-13 15:19 ` Antonio Quartulli [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9afd9031-9a66-4c13-b1a2-e1da62ef5e69@mandelbit.com \
--to=antonio@mandelbit.com \
--cc=andrew+netdev@lunn.ch \
--cc=ast@kernel.org \
--cc=bpf@vger.kernel.org \
--cc=daniel@iogearbox.net \
--cc=davem@davemloft.net \
--cc=edumazet@kernel.org \
--cc=eperezma@redhat.com \
--cc=hawk@kernel.org \
--cc=horms@kernel.org \
--cc=jasowangio@gmail.com \
--cc=john.fastabend@gmail.com \
--cc=kuba@kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=maheshb@google.com \
--cc=mst@redhat.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=peterpenkov96@gmail.com \
--cc=sdf@fomichev.me \
--cc=shuah@kernel.org \
--cc=virtualization@lists.linux.dev \
--cc=willemdebruijn.kernel@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox