From: David Ahern <dsahern@gmail.com>
To: Jakub Kicinski <jakub.kicinski@netronome.com>, davem@davemloft.net
Cc: netdev@vger.kernel.org, oss-drivers@netronome.com, joe@perches.com
Subject: Re: [PATCH net v2] ipv6: route: place a warning with duplicated string with correct extack
Date: Tue, 15 Jan 2019 20:54:00 -0700 [thread overview]
Message-ID: <9b02168e-c41b-7dc4-61fd-5cbc4492e92d@gmail.com> (raw)
In-Reply-To: <20190114185245.31416-1-jakub.kicinski@netronome.com>
On 1/14/19 11:52 AM, Jakub Kicinski wrote:
> "IPv6: " prefix is already added by pr_fmt, no need to include
> it again in the pr_warn() format. The message predates extack
> support, we can replace the whole thing with an extack message.
>
> Suggested-by: David Ahern <dsahern@gmail.com>
> Signed-off-by: Jakub Kicinski <jakub.kicinski@netronome.com>
> ---
> net/ipv6/route.c | 14 ++------------
> 1 file changed, 2 insertions(+), 12 deletions(-)
>
Reviewed-by: David Ahern <dsahern@gmail.com>
next prev parent reply other threads:[~2019-01-16 3:54 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-12 20:45 [PATCH net] ipv6: route: remove duplicated string from error message Jakub Kicinski
2019-01-12 21:07 ` Joe Perches
2019-01-13 16:08 ` David Ahern
2019-01-14 18:38 ` Jakub Kicinski
2019-01-14 18:52 ` [PATCH net v2] ipv6: route: place a warning with duplicated string with correct extack Jakub Kicinski
2019-01-16 3:54 ` David Ahern [this message]
2019-01-16 22:07 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9b02168e-c41b-7dc4-61fd-5cbc4492e92d@gmail.com \
--to=dsahern@gmail.com \
--cc=davem@davemloft.net \
--cc=jakub.kicinski@netronome.com \
--cc=joe@perches.com \
--cc=netdev@vger.kernel.org \
--cc=oss-drivers@netronome.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).