netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Florian Fainelli <f.fainelli@gmail.com>
To: Arkadi Sharshevsky <arkadis@mellanox.com>, netdev@vger.kernel.org
Cc: davem@davemloft.net, jiri@resnulli.us, ivecera@redhat.com,
	andrew@lunn.ch, vivien.didelot@savoirfairelinux.com,
	Woojung.Huh@microchip.com, stephen@networkplumber.org,
	mlxsw@mellanox.com
Subject: Re: [PATCH net-next RFC 08/12] net: dsa: Remove support for bypass bridge port attributes/vlan set
Date: Wed, 5 Jul 2017 12:45:55 -0700	[thread overview]
Message-ID: <9b066beb-190f-ddc8-74bd-c59cee98d059@gmail.com> (raw)
In-Reply-To: <1499268990-19251-9-git-send-email-arkadis@mellanox.com>

On 07/05/2017 08:36 AM, Arkadi Sharshevsky wrote:
> The bridge port attributes/vlan for DSA devices should be set only
> from bridge code. Furthermore, The vlans are synced totally with the
> bridge so there is no need for special dump support.
> 
> Signed-off-by: Arkadi Sharshevsky <arkadis@mellanox.com>

I would be more comfortable if we still had a way to dump HW entries by
calling into drivers, because it's useful for debugging, and doing that
using standard tools plus an additional flag for instance:

bridge fdb show

would dump the SW-maintained VLANs, but:

bridge fdb show hw

would dump the HW-maintained VLANs, or any flag name really, but the
point is that we can keep using a standard tool to expose debugging
features. debugfs (or something else) could be used, but was rejected by
David.

Also, technically, it ought to be possible to configure a port's VLAN
membership (although using poor semantics) through e.g: vconfig add
sw0p0 1, which would call ndo_vlan_rx_add_vid() (DSA does not support it
but mlxsw does), and so being able to dump that configuration would be
somehow helpful.
-- 
Florian

  reply	other threads:[~2017-07-05 19:46 UTC|newest]

Thread overview: 35+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-07-05 15:36 [PATCH net-next RFC 00/12] Change DSA's FDB API and perform switchdev cleanup Arkadi Sharshevsky
2017-07-05 15:36 ` [PATCH net-next RFC 01/12] net: dsa: Change DSA slave FDB API to be switchdev independent Arkadi Sharshevsky
2017-07-05 19:13   ` Florian Fainelli
2017-07-05 15:36 ` [PATCH net-next RFC 02/12] net: dsa: Remove prepare phase for FDB Arkadi Sharshevsky
2017-07-05 19:25   ` Florian Fainelli
2017-07-06 18:20   ` Vivien Didelot
2017-07-05 15:36 ` [PATCH net-next RFC 03/12] net: dsa: Remove switchdev dependency from DSA switch notifier chain Arkadi Sharshevsky
2017-07-05 19:26   ` Florian Fainelli
2017-07-06 18:42   ` Vivien Didelot
2017-07-05 15:36 ` [PATCH net-next RFC 04/12] net: dsa: Add ordered workqueue Arkadi Sharshevsky
2017-07-05 19:37   ` Florian Fainelli
2017-07-06 18:45     ` Vivien Didelot
2017-07-09 12:56       ` Arkadi Sharshevsky
2017-07-05 15:36 ` [PATCH net-next RFC 05/12] net: dsa: Add support for learning FDB through notification Arkadi Sharshevsky
2017-07-05 19:35   ` Florian Fainelli
2017-07-06 13:04     ` Arkadi Sharshevsky
2017-07-10 20:59       ` Vivien Didelot
2017-07-11 10:26         ` Arkadi Sharshevsky
2017-07-11 15:05           ` Nikolay Aleksandrov
2017-07-12 11:23             ` Arkadi Sharshevsky
2017-07-12 11:42               ` Nikolay Aleksandrov
2017-07-05 15:36 ` [PATCH net-next RFC 06/12] net: dsa: Remove support for FDB add/del via SELF Arkadi Sharshevsky
2017-07-05 15:36 ` [PATCH net-next RFC 07/12] net: dsa: Add support for querying supported bridge flags Arkadi Sharshevsky
2017-07-05 15:36 ` [PATCH net-next RFC 08/12] net: dsa: Remove support for bypass bridge port attributes/vlan set Arkadi Sharshevsky
2017-07-05 19:45   ` Florian Fainelli [this message]
2017-07-06 11:00     ` Arkadi Sharshevsky
2017-07-06 21:36       ` Florian Fainelli
2017-07-09 13:56         ` Arkadi Sharshevsky
2017-07-10 17:13     ` Vivien Didelot
2017-07-05 15:36 ` [PATCH net-next RFC 09/12] net: dsa: Remove redundant MDB dump support Arkadi Sharshevsky
2017-07-05 15:36 ` [PATCH net-next RFC 10/12] net: dsa: Move FDB dump implementation inside DSA Arkadi Sharshevsky
2017-07-10 19:36   ` Vivien Didelot
2017-07-11  8:32     ` Arkadi Sharshevsky
2017-07-05 15:36 ` [PATCH net-next RFC 11/12] net: bridge: Remove FDB deletion through switchdev object Arkadi Sharshevsky
2017-07-05 15:36 ` [PATCH net-next RFC 12/12] net: switchdev: Remove bridge bypass support from switchdev Arkadi Sharshevsky

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=9b066beb-190f-ddc8-74bd-c59cee98d059@gmail.com \
    --to=f.fainelli@gmail.com \
    --cc=Woojung.Huh@microchip.com \
    --cc=andrew@lunn.ch \
    --cc=arkadis@mellanox.com \
    --cc=davem@davemloft.net \
    --cc=ivecera@redhat.com \
    --cc=jiri@resnulli.us \
    --cc=mlxsw@mellanox.com \
    --cc=netdev@vger.kernel.org \
    --cc=stephen@networkplumber.org \
    --cc=vivien.didelot@savoirfairelinux.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).