Re: [PATCH net-next 1/2] mlx4: update mlx4_clock_read() to provide pre/post tstamps

[Paolo Abeni <pabeni@redhat.com>]

On 10/10/24 10:36, Paolo Abeni wrote:
> On 10/8/24 12:46, Mahesh Bandewar wrote:
>> The mlx4_clock_read() function, when called by cycle_counter->read(),
>> previously only returned the raw cycle count. However, for PTP helpers
>> like gettimex64(), which require pre- and post-timestamps, simply
>> returning raw cycles is insufficient. It also needs to provide the
>> necessary timestamps.
>>
>> This update modifies mlx4_clock_read() to return both the cycles and
>> the required timestamps. Additionally, mlx4_en_read_clock() is now
>> responsible for reading and updating the clock_cache. This allows
>> another function, mlx4_en_read_clock_cache(), to act as the cycle
>> reader for cycle_counter->read(), preserving the same interface.
> 
> It looks like this patch should be split in two, the first one could be
> possibly 'net' material and just fix gettimex64()/mlx4_read_clock() and
> the other one introduces the cache.

My bad, I was too hasty and actually missed that the gettimex64() 
callback is implemented in the next patch.

The main point still remains: the cache infra should be in a separate 
patch: it can introduce side effects and we want to be able to bisect.

Thanks,

Paolo