From: David Ahern <dsahern@gmail.com>
To: Hangbin Liu <liuhangbin@gmail.com>, David Miller <davem@davemloft.net>
Cc: Phil Sutter <phil@nwl.cc>,
netdev@vger.kernel.org,
Stephen Hemminger <stephen@networkplumber.org>
Subject: Re: [PATCH net] vxlan: use nla_put_flag for ttl inherit
Date: Fri, 28 Sep 2018 11:56:10 -0600 [thread overview]
Message-ID: <9b444c06-d3d3-1bbe-1edd-e2fe7ec1932b@gmail.com> (raw)
In-Reply-To: <20180928123858.GF24677@leo.usersys.redhat.com>
On 9/28/18 6:38 AM, Hangbin Liu wrote:
> On Fri, Sep 28, 2018 at 12:37:00PM +0200, Phil Sutter wrote:
>> On Fri, Sep 28, 2018 at 09:08:26AM +0800, Hangbin Liu wrote:
>>> Phil pointed out that there is a mismatch between vxlan and geneve ttl inherit.
>>> We should define it as a flag and use nla_put_flag to export this opiton.
>>
>> s/opiton/option/
>>
>> Apart from that, LGTM!
>>
>> Thanks, Phil
>
> Opps, sorry...
>
> Hi David,
>
> Should I re-send a patch or will you help fix it directly?
>
> Thanks
> Hangbin
>
you have this targeted at net; is it a bug in current iproute2 or an
update to a new feature in -next?
next prev parent reply other threads:[~2018-09-29 0:21 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-09-28 1:08 [PATCH net] vxlan: use nla_put_flag for ttl inherit Hangbin Liu
2018-09-28 10:37 ` Phil Sutter
2018-09-28 12:38 ` Hangbin Liu
2018-09-28 17:56 ` David Ahern [this message]
2018-09-29 9:01 ` Hangbin Liu
2018-09-28 17:57 ` David Ahern
2018-10-04 16:19 ` Stephen Hemminger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9b444c06-d3d3-1bbe-1edd-e2fe7ec1932b@gmail.com \
--to=dsahern@gmail.com \
--cc=davem@davemloft.net \
--cc=liuhangbin@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=phil@nwl.cc \
--cc=stephen@networkplumber.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).