From mboxrd@z Thu Jan 1 00:00:00 1970 From: David Ahern Subject: Re: [PATCH net] vxlan: use nla_put_flag for ttl inherit Date: Fri, 28 Sep 2018 11:56:10 -0600 Message-ID: <9b444c06-d3d3-1bbe-1edd-e2fe7ec1932b@gmail.com> References: <1538096906-20866-1-git-send-email-liuhangbin@gmail.com> <20180928103700.GC14666@orbyte.nwl.cc> <20180928123858.GF24677@leo.usersys.redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Cc: Phil Sutter , netdev@vger.kernel.org, Stephen Hemminger To: Hangbin Liu , David Miller Return-path: Received: from mail-pg1-f193.google.com ([209.85.215.193]:41394 "EHLO mail-pg1-f193.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726114AbeI2AVG (ORCPT ); Fri, 28 Sep 2018 20:21:06 -0400 Received: by mail-pg1-f193.google.com with SMTP id z3-v6so4983750pgv.8 for ; Fri, 28 Sep 2018 10:56:12 -0700 (PDT) In-Reply-To: <20180928123858.GF24677@leo.usersys.redhat.com> Content-Language: en-US Sender: netdev-owner@vger.kernel.org List-ID: On 9/28/18 6:38 AM, Hangbin Liu wrote: > On Fri, Sep 28, 2018 at 12:37:00PM +0200, Phil Sutter wrote: >> On Fri, Sep 28, 2018 at 09:08:26AM +0800, Hangbin Liu wrote: >>> Phil pointed out that there is a mismatch between vxlan and geneve ttl inherit. >>> We should define it as a flag and use nla_put_flag to export this opiton. >> >> s/opiton/option/ >> >> Apart from that, LGTM! >> >> Thanks, Phil > > Opps, sorry... > > Hi David, > > Should I re-send a patch or will you help fix it directly? > > Thanks > Hangbin > you have this targeted at net; is it a bug in current iproute2 or an update to a new feature in -next?