Re: [PATCH net-next] r8169: remove 1000/Half from supported modes

[Florian Fainelli <f.fainelli@gmail.com>]

On 5/28/19 9:43 AM, Heiner Kallweit wrote:
> MAC on the GBit versions supports 1000/Full only, however the PHY
> partially claims to support 1000/Half. So let's explicitly remove
> this mode.
> 
> Signed-off-by: Heiner Kallweit <hkallweit1@gmail.com>

Don't you want a Fixes: tag for that?

> ---
>  drivers/net/ethernet/realtek/r8169.c | 5 ++++-
>  1 file changed, 4 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/net/ethernet/realtek/r8169.c b/drivers/net/ethernet/realtek/r8169.c
> index 61e7eef5e..0239a3de2 100644
> --- a/drivers/net/ethernet/realtek/r8169.c
> +++ b/drivers/net/ethernet/realtek/r8169.c
> @@ -6397,7 +6397,10 @@ static int r8169_phy_connect(struct rtl8169_private *tp)
>  	if (ret)
>  		return ret;
>  
> -	if (!tp->supports_gmii)
> +	if (tp->supports_gmii)
> +		phy_remove_link_mode(phydev,
> +				     ETHTOOL_LINK_MODE_1000baseT_Half_BIT);
> +	else
>  		phy_set_max_speed(phydev, SPEED_100);
>  
>  	phy_support_asym_pause(phydev);
> 


-- 
Florian