Re: [PATCH v3 net-next 2/5] psp: add new netlink cmd for dev-assoc and dev-disassoc

[Daniel Zahka <daniel.zahka@gmail.com>]

On 3/9/26 2:34 PM, Wei Wang wrote:
> @@ -131,8 +263,7 @@ void psp_nl_notify_dev(struct psp_dev *psd, u32 cmd)
>   	struct genl_info info;
>   	struct sk_buff *ntf;
>   
> -	if (!genl_has_listeners(&psp_nl_family, dev_net(psd->main_netdev),
> -				PSP_NLGRP_MGMT))
> +	if (!psp_nl_has_listeners_any_ns(psd, PSP_NLGRP_MGMT))
>   		return;
>   
>   	ntf = genlmsg_new(GENLMSG_DEFAULT_SIZE, GFP_KERNEL);
> @@ -140,13 +271,13 @@ void psp_nl_notify_dev(struct psp_dev *psd, u32 cmd)
>   		return;
>   
>   	genl_info_init_ntf(&info, &psp_nl_family, cmd);
> +	genl_info_net_set(&info, dev_net(psd->main_netdev));
>   	if (psp_nl_dev_fill(psd, ntf, &info)) {
>   		nlmsg_free(ntf);
>   		return;
>   	}
>   
> -	genlmsg_multicast_netns(&psp_nl_family, dev_net(psd->main_netdev), ntf,
> -				0, PSP_NLGRP_MGMT, GFP_KERNEL);
> +	psp_nl_multicast_all_ns(psd, ntf, PSP_NLGRP_MGMT);
>   }

I don't think this will work correctly when there are listeners outside 
of dev_net(psd->main_netdev). psp_nl_dev_fill() will prepare a 
notification containing the unfiltered assoc list, but then that will be 
broadcast out to all listeners regardless of netns, so those listeners 
will see peer nsids relative to a different netns.