From: xiaofeis@codeaurora.org
To: Andrew Lunn <andrew@lunn.ch>
Cc: Vinod Koul <vkoul@kernel.org>,
"David S. Miller" <davem@davemloft.net>,
linux-arm-msm@vger.kernel.org,
Bjorn Andersson <bjorn.andersson@linaro.org>,
Vivien Didelot <vivien.didelot@gmail.com>,
Florian Fainelli <f.fainelli@gmail.com>,
Niklas Cassel <niklas.cassel@linaro.org>,
netdev@vger.kernel.org
Subject: Re: [PATCH] net: dsa: Inherit dev addr from master
Date: Wed, 27 Mar 2019 12:09:07 +0800 [thread overview]
Message-ID: <9b81c4c88090606c25c75196ed2ec79c@codeaurora.org> (raw)
In-Reply-To: <20190225132107.GG20855@lunn.ch>
On 2019-02-25 21:21, Andrew Lunn wrote:
>> I think we can remove the first inherit, but if keep it, we can see
>> consistent address output by ifconfig -a before open master and slave
>> interface.
>
> True
>
> But it also means we see inconsistent MAC addresses on the master. The
> MAC address changes on open.
>
> Maybe it would be better to change your master so it sets its MAC
> address during probe? Everything is then consistent all the time.
>
> Andrew
I'm trying to suggest our master driver owner to set MAC address during
probe.
I found in kernel, different driver has different implementation, some
set it in probe, while
some in open. DSA should be generic to work with all these master
drivers. I think this change
can help. Thanks.
prev parent reply other threads:[~2019-03-27 4:09 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-22 12:56 [PATCH] net: dsa: Inherit dev addr from master Vinod Koul
2019-02-22 14:30 ` Andrew Lunn
2019-02-25 13:13 ` xiaofeis
2019-02-25 13:21 ` Andrew Lunn
2019-03-27 4:09 ` xiaofeis [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9b81c4c88090606c25c75196ed2ec79c@codeaurora.org \
--to=xiaofeis@codeaurora.org \
--cc=andrew@lunn.ch \
--cc=bjorn.andersson@linaro.org \
--cc=davem@davemloft.net \
--cc=f.fainelli@gmail.com \
--cc=linux-arm-msm@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=niklas.cassel@linaro.org \
--cc=vivien.didelot@gmail.com \
--cc=vkoul@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).