From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A3EBFC43381 for ; Wed, 27 Mar 2019 04:09:10 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 6B45B206DF for ; Wed, 27 Mar 2019 04:09:10 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="key not found in DNS" (0-bit key) header.d=codeaurora.org header.i=@codeaurora.org header.b="NUQHUZt3"; dkim=fail reason="key not found in DNS" (0-bit key) header.d=codeaurora.org header.i=@codeaurora.org header.b="X4/AdH4S" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1725786AbfC0EJJ (ORCPT ); Wed, 27 Mar 2019 00:09:09 -0400 Received: from smtp.codeaurora.org ([198.145.29.96]:55592 "EHLO smtp.codeaurora.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725616AbfC0EJJ (ORCPT ); Wed, 27 Mar 2019 00:09:09 -0400 Received: by smtp.codeaurora.org (Postfix, from userid 1000) id 631DA60E3F; Wed, 27 Mar 2019 04:09:08 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=codeaurora.org; s=default; t=1553659748; bh=Fem0QGcjdq5qD2U7+b0exAkdB3r6BLF+pntdpqgmIqY=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=NUQHUZt3uhykvakkFumnDUbVh1T7x1MJgS5XVuWenDWj48Q2KmOSw9Qy/3PqNmXaF PL9YPo7+WngmQfLMMVBUimUNtcWjBFzCvCjUdoxc2pqCdjTO+cjXgT7QSJgY3UsFWq s77yJ+8+AHTG30Q4EpzbaXXcKiEKippLQFVzTk70= Received: from mail.codeaurora.org (localhost.localdomain [127.0.0.1]) by smtp.codeaurora.org (Postfix) with ESMTP id B499060A0A; Wed, 27 Mar 2019 04:09:07 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=codeaurora.org; s=default; t=1553659747; bh=Fem0QGcjdq5qD2U7+b0exAkdB3r6BLF+pntdpqgmIqY=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=X4/AdH4SuvePhlfXJPuxzLK0HC7d7ey5LMyl85N/fZI+whYDDSlfrnw2vcjnkIEue KO+AAdGbZyfVzPR6RqX4EfJB+lnqpNdTtjLnvttJhz4XVt+Qd4Vn6p4asL8Z9/k4yw ZTxxEfBgGxETcGqARnLW/1PZ0nEaczv10XPw8Nys= MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII; format=flowed Content-Transfer-Encoding: 7bit Date: Wed, 27 Mar 2019 12:09:07 +0800 From: xiaofeis@codeaurora.org To: Andrew Lunn Cc: Vinod Koul , "David S. Miller" , linux-arm-msm@vger.kernel.org, Bjorn Andersson , Vivien Didelot , Florian Fainelli , Niklas Cassel , netdev@vger.kernel.org Subject: Re: [PATCH] net: dsa: Inherit dev addr from master In-Reply-To: <20190225132107.GG20855@lunn.ch> References: <20190222125654.12478-1-vkoul@kernel.org> <20190222143003.GL5653@lunn.ch> <441ae81a814498876e4cfed6fd5b7bcb@codeaurora.org> <20190225132107.GG20855@lunn.ch> Message-ID: <9b81c4c88090606c25c75196ed2ec79c@codeaurora.org> X-Sender: xiaofeis@codeaurora.org User-Agent: Roundcube Webmail/1.2.5 Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On 2019-02-25 21:21, Andrew Lunn wrote: >> I think we can remove the first inherit, but if keep it, we can see >> consistent address output by ifconfig -a before open master and slave >> interface. > > True > > But it also means we see inconsistent MAC addresses on the master. The > MAC address changes on open. > > Maybe it would be better to change your master so it sets its MAC > address during probe? Everything is then consistent all the time. > > Andrew I'm trying to suggest our master driver owner to set MAC address during probe. I found in kernel, different driver has different implementation, some set it in probe, while some in open. DSA should be generic to work with all these master drivers. I think this change can help. Thanks.