From: Paolo Abeni <pabeni@redhat.com>
To: Kuniyuki Iwashima <kuniyu@amazon.com>,
Eric Dumazet <edumazet@google.com>
Cc: Kuniyuki Iwashima <kuni1840@gmail.com>,
netdev@vger.kernel.org, "David S. Miller" <davem@davemloft.net>,
Jakub Kicinski <kuba@kernel.org>
Subject: Re: [PATCH v3 net-next 3/4] rtnetlink: Add assertion helpers for per-netns RTNL.
Date: Tue, 8 Oct 2024 13:39:24 +0200 [thread overview]
Message-ID: <9bb97d2c-878f-479a-b092-8e74893ebb2d@redhat.com> (raw)
In-Reply-To: <20241004221031.77743-4-kuniyu@amazon.com>
Hi,
On 10/5/24 00:10, Kuniyuki Iwashima wrote:
> Once an RTNL scope is converted with rtnl_net_lock(), we will replace
> RTNL helper functions inside the scope with the following per-netns
> alternatives:
>
> ASSERT_RTNL() -> ASSERT_RTNL_NET(net)
> rcu_dereference_rtnl(p) -> rcu_dereference_rtnl_net(net, p)
>
> Note that the per-netns helpers are equivalent to the conventional
> helpers unless CONFIG_DEBUG_NET_SMALL_RTNL is enabled.
>
> Signed-off-by: Kuniyuki Iwashima <kuniyu@amazon.com>
I guess Kuniyuki stripped the ack received on v2 due to the edit here.
@Kuniyuki: in the next iterations, please include a per patch changelog
to simplify the review.
@Eric: would you mind acking it again? Thanks!
Paolo
next prev parent reply other threads:[~2024-10-08 11:39 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-04 22:10 [PATCH v3 net-next 0/4] rtnetlink: Per-netns RTNL Kuniyuki Iwashima
2024-10-04 22:10 ` [PATCH v3 net-next 1/4] Revert "rtnetlink: add guard for RTNL" Kuniyuki Iwashima
2024-10-04 22:10 ` [PATCH v3 net-next 2/4] rtnetlink: Add per-netns RTNL Kuniyuki Iwashima
2024-10-05 8:16 ` Eric Dumazet
2024-10-04 22:10 ` [PATCH v3 net-next 3/4] rtnetlink: Add assertion helpers for " Kuniyuki Iwashima
2024-10-08 11:39 ` Paolo Abeni [this message]
2024-10-08 11:46 ` Eric Dumazet
2024-10-08 16:12 ` Kuniyuki Iwashima
2024-10-08 11:48 ` Eric Dumazet
2024-10-04 22:10 ` [PATCH v3 net-next 4/4] rtnetlink: Add ASSERT_RTNL_NET() placeholder for netdev notifier Kuniyuki Iwashima
2024-10-08 13:30 ` [PATCH v3 net-next 0/4] rtnetlink: Per-netns RTNL patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9bb97d2c-878f-479a-b092-8e74893ebb2d@redhat.com \
--to=pabeni@redhat.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=kuba@kernel.org \
--cc=kuni1840@gmail.com \
--cc=kuniyu@amazon.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).