From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from lindbergh.monkeyblade.net (lindbergh.monkeyblade.net [23.128.96.19]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4E16E39A; Sat, 23 Sep 2023 01:41:46 +0000 (UTC) Received: from omta040.useast.a.cloudfilter.net (omta040.useast.a.cloudfilter.net [44.202.169.39]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 81FC71AB; Fri, 22 Sep 2023 18:41:45 -0700 (PDT) Received: from eig-obgw-6007a.ext.cloudfilter.net ([10.0.30.247]) by cmsmtp with ESMTP id jjHbq7WX7yYOwjreSqyWYO; Sat, 23 Sep 2023 01:41:44 +0000 Received: from gator4166.hostgator.com ([108.167.133.22]) by cmsmtp with ESMTPS id jreRqje4O43lpjreRq8PIr; Sat, 23 Sep 2023 01:41:43 +0000 X-Authority-Analysis: v=2.4 cv=d+nmdDvE c=1 sm=1 tr=0 ts=650e4257 a=1YbLdUo/zbTtOZ3uB5T3HA==:117 a=P7XfKmiOJ4/qXqHZrN7ymg==:17 a=OWjo9vPv0XrRhIrVQ50Ab3nP57M=:19 a=dLZJa+xiwSxG16/P+YVxDGlgEgI=:19 a=IkcTkHD0fZMA:10 a=zNV7Rl7Rt7sA:10 a=wYkD_t78qR0A:10 a=NEAV23lmAAAA:8 a=8AirrxEcAAAA:8 a=J1Y8HTJGAAAA:8 a=1XWaLZrsAAAA:8 a=VwQbUJbxAAAA:8 a=20KFwNOVAAAA:8 a=cm27Pg_UAAAA:8 a=wH_VP6JpHQxiM5NuicYA:9 a=QEXdDO2ut3YA:10 a=ST-jHhOKWsTCqRlWije3:22 a=y1Q9-5lHfBjTkpIzbSAN:22 a=AjGcO6oz07-iQ99wixmX:22 a=xmb-EsYY8bH0VWELuYED:22 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=embeddedor.com; s=default; h=Content-Transfer-Encoding:Content-Type: In-Reply-To:From:References:Cc:To:Subject:MIME-Version:Date:Message-ID:Sender :Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help: List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=MzVmwOfKB5MwMYw1j9M03a/MmO+PWTyuUR8xCl+K+/s=; b=qbuwD3+uHDTnn4bXL6W2KVl9Wl Qi8GHz6cRRQEgeJLXFmpKyQGtH9xrNDv6IdLN4A8lUROSx63oc+UgIPXNn7ODLavpTylUm5oytsVz 7qiHE6UkkxYR7riDWB3I1a7blFwCqxfKKHJZ4U8ijgholpaPULo9sRcRYm9rNXAywPwMB/6dkn58k 8+VxF5Pa0AaqRHyRYBrW7iAqMXhrVs8I/q0+biL/Qlvca1+Gt4LOToNHChe1gICvXtcbMrEF3g/KQ ea+hEpkSFGm5fq8pX4mehXnHKd89T/UgHuvU+ay4zZRaGIx8/WqRfAjom93zcvgtGLGLofqZyiHcN jIQE407Q==; Received: from [94.239.20.48] (port=58636 helo=[192.168.1.98]) by gator4166.hostgator.com with esmtpsa (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256 (Exim 4.96) (envelope-from ) id 1qjkNc-0005fN-11; Fri, 22 Sep 2023 12:55:52 -0500 Message-ID: <9bc8cfed-4577-f303-5186-0369f96cf8a7@embeddedor.com> Date: Fri, 22 Sep 2023 19:56:49 -0600 Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.15.1 Subject: Re: [PATCH 11/14] net: enetc: Annotate struct enetc_psfp_gate with __counted_by Content-Language: en-US To: Kees Cook , Jakub Kicinski Cc: Claudiu Manoil , Vladimir Oltean , "David S. Miller" , Eric Dumazet , Paolo Abeni , netdev@vger.kernel.org, Jamal Hadi Salim , David Ahern , Martin KaFai Lau , "Gustavo A. R. Silva" , Alexei Starovoitov , Yisen Zhuang , Salil Mehta , "K. Y. Srinivasan" , Haiyang Zhang , Wei Liu , Dexuan Cui , Long Li , Ajay Sharma , Alex Elder , Pravin B Shelar , Shaokun Zhang , Cong Wang , Jiri Pirko , Nathan Chancellor , Nick Desaulniers , Tom Rix , Simon Horman , linux-kernel@vger.kernel.org, linux-hyperv@vger.kernel.org, linux-rdma@vger.kernel.org, dev@openvswitch.org, linux-parisc@vger.kernel.org, llvm@lists.linux.dev, linux-hardening@vger.kernel.org References: <20230922172449.work.906-kees@kernel.org> <20230922172858.3822653-11-keescook@chromium.org> From: "Gustavo A. R. Silva" In-Reply-To: <20230922172858.3822653-11-keescook@chromium.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - gator4166.hostgator.com X-AntiAbuse: Original Domain - vger.kernel.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - embeddedor.com X-BWhitelist: no X-Source-IP: 94.239.20.48 X-Source-L: No X-Exim-ID: 1qjkNc-0005fN-11 X-Source: X-Source-Args: X-Source-Dir: X-Source-Sender: ([192.168.1.98]) [94.239.20.48]:58636 X-Source-Auth: gustavo@embeddedor.com X-Email-Count: 0 X-Org: HG=hgshared;ORG=hostgator; X-Source-Cap: Z3V6aWRpbmU7Z3V6aWRpbmU7Z2F0b3I0MTY2Lmhvc3RnYXRvci5jb20= X-Local-Domain: yes X-CMAE-Envelope: MS4xfHc2+7/44s/62cxPYuyA5fcVNRoiyG2bKVsWz3fds8iD+EMQw/1fy+5UnlwnseotB+VsnBeYZA0Q9+21dB/N8MwlZIRpEDc5tlYlPZBNgEa9HkipO6C8 XDokKC0wErsB/pzLIZr3nEgFYkOE4loFnzMX66f3mVR8mUPa+Ttk4gDzV7AjVu8D/tk8NPY/STm24KHPsVVeuvd1NWXj66HLiNUNAng7PtOWdJK7uahfgXzq ZzvJRm93TOIMTyLpdnqdW7vewxKqGFYjj4TjWqJ11orlfjmms6zLxLsMxnLf43JBplwOoPXBcIafFsnUh37swKyXrSss1SbP6n7k4P0fNxAMKnbQntoy/Bwo 4LH8MYDuE8VVKW5t9A/K1UPX2cSC+uK2Zvk/nfCLrNILqnX0VM430vQ5XsLkOadJQxanRk4a X-Spam-Status: No, score=-3.6 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A, RCVD_IN_DNSWL_BLOCKED,RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net On 9/22/23 11:28, Kees Cook wrote: > Prepare for the coming implementation by GCC and Clang of the __counted_by > attribute. Flexible array members annotated with __counted_by can have > their accesses bounds-checked at run-time checking via CONFIG_UBSAN_BOUNDS > (for array indexing) and CONFIG_FORTIFY_SOURCE (for strcpy/memcpy-family > functions). > > As found with Coccinelle[1], add __counted_by for struct enetc_psfp_gate. > > [1] https://github.com/kees/kernel-tools/blob/trunk/coccinelle/examples/counted_by.cocci > > Cc: Claudiu Manoil > Cc: Vladimir Oltean > Cc: "David S. Miller" > Cc: Eric Dumazet > Cc: Jakub Kicinski > Cc: Paolo Abeni > Cc: netdev@vger.kernel.org > Signed-off-by: Kees Cook Reviewed-by: Gustavo A. R. Silva Thanks -- Gustavo > --- > drivers/net/ethernet/freescale/enetc/enetc_qos.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/net/ethernet/freescale/enetc/enetc_qos.c b/drivers/net/ethernet/freescale/enetc/enetc_qos.c > index 2513b44056c1..b65da49dd926 100644 > --- a/drivers/net/ethernet/freescale/enetc/enetc_qos.c > +++ b/drivers/net/ethernet/freescale/enetc/enetc_qos.c > @@ -443,7 +443,7 @@ struct enetc_psfp_gate { > u32 num_entries; > refcount_t refcount; > struct hlist_node node; > - struct action_gate_entry entries[]; > + struct action_gate_entry entries[] __counted_by(num_entries); > }; > > /* Only enable the green color frame now