From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from out-182.mta0.migadu.com (out-182.mta0.migadu.com [91.218.175.182]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8D156395D8F for ; Mon, 30 Mar 2026 19:09:52 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=91.218.175.182 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774897794; cv=none; b=kprsZjaaUVDyPyxpyToI/gTv1a2eEKRHzWWZ0AsTlt44PUnitvqQfnWICjOwa4duZnV5VewYMb0LokJbYXT8Bh/uNoIM00M6eFK3JCcuuV7QE3fBZ2ULDvVfiqQeb09LxbkNrXdRU4VErJRh78FIGvtEjogH3+0fqFDComvgdqw= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774897794; c=relaxed/simple; bh=JcBis6pTBzmgsNrafAyetZ0ru9qV/HJ77GoeevbHE3U=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=hTihk2AfRPlI+F6RjRQPt7tN7FBzz1qPpfAqujO8ziDz6D7G7PB14wzAAXo9Pg0nZAVdwMViTUVHLLK/T1xu2tUxL5tV8UP1NnhAPoFMzY/9gXcyRPd1d04wP7FERPl4vK8sFpk3XYx4p3FVcJUTQIUUHm6mUSAOtnxIzBf07Ww= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.dev; spf=pass smtp.mailfrom=linux.dev; dkim=pass (1024-bit key) header.d=linux.dev header.i=@linux.dev header.b=tPR/aBRW; arc=none smtp.client-ip=91.218.175.182 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.dev Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linux.dev Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linux.dev header.i=@linux.dev header.b="tPR/aBRW" Message-ID: <9bec08b6-c97b-4e04-8940-d08afa831722@linux.dev> DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1774897790; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=fAc7YHSQrwJfKCXX2f47zs5maWQYLeQ6iIc2j8sAEX0=; b=tPR/aBRWQ8VkUoJzfAOYOUvQmkoyvMwtDry/5SZEN21PjHOm7y6bKd0IAplfRoed63tUu/ Sb99GaNLgRWU71EMf9gWSKdfP5Rsb3lTobGalag4XHMXBRLAwpyJT9VVg932E7RM5xIFAF CNlDqcaku08E0KDQgTF7EtzQZ0p1IMo= Date: Mon, 30 Mar 2026 15:09:38 -0400 Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Subject: Re: [PATCH net V2 1/2] net: xilinx: axienet: Correct BD length masks to match AXIDMA IP spec To: Suraj Gupta , Radhey Shyam Pandey , Andrew Lunn , "David S . Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni Cc: Michal Simek , Daniel Borkmann , Ariane Keller , netdev@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org References: <20260327073238.134948-1-suraj.gupta2@amd.com> <20260327073238.134948-2-suraj.gupta2@amd.com> Content-Language: en-US X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: Sean Anderson In-Reply-To: <20260327073238.134948-2-suraj.gupta2@amd.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Migadu-Flow: FLOW_OUT On 3/27/26 03:32, Suraj Gupta wrote: > The XAXIDMA_BD_CTRL_LENGTH_MASK and XAXIDMA_BD_STS_ACTUAL_LEN_MASK > macros were defined as 0x007FFFFF (23 bits), but the AXI DMA IP > product guide (PG021) specifies the buffer length field as bits 25:0 > (26 bits). Update both masks to match the IP documentation. > > In practice this had no functional impact, since Ethernet frames are > far smaller than 2^23 bytes and the extra bits were always zero, but > the masks should still reflect the hardware specification. > > Fixes: 8a3b7a252dca ("drivers/net/ethernet/xilinx: added Xilinx AXI Ethernet driver") > Signed-off-by: Suraj Gupta > --- > drivers/net/ethernet/xilinx/xilinx_axienet.h | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/net/ethernet/xilinx/xilinx_axienet.h b/drivers/net/ethernet/xilinx/xilinx_axienet.h > index 5ff742103beb..fcd3aaef27fc 100644 > --- a/drivers/net/ethernet/xilinx/xilinx_axienet.h > +++ b/drivers/net/ethernet/xilinx/xilinx_axienet.h > @@ -105,7 +105,7 @@ > #define XAXIDMA_BD_HAS_DRE_MASK 0xF00 /* Whether has DRE mask */ > #define XAXIDMA_BD_WORDLEN_MASK 0xFF /* Whether has DRE mask */ > > -#define XAXIDMA_BD_CTRL_LENGTH_MASK 0x007FFFFF /* Requested len */ > +#define XAXIDMA_BD_CTRL_LENGTH_MASK GENMASK(25, 0) /* Requested len */ > #define XAXIDMA_BD_CTRL_TXSOF_MASK 0x08000000 /* First tx packet */ > #define XAXIDMA_BD_CTRL_TXEOF_MASK 0x04000000 /* Last tx packet */ > #define XAXIDMA_BD_CTRL_ALL_MASK 0x0C000000 /* All control bits */ > @@ -130,7 +130,7 @@ > #define XAXIDMA_BD_CTRL_TXEOF_MASK 0x04000000 /* Last tx packet */ > #define XAXIDMA_BD_CTRL_ALL_MASK 0x0C000000 /* All control bits */ > > -#define XAXIDMA_BD_STS_ACTUAL_LEN_MASK 0x007FFFFF /* Actual len */ > +#define XAXIDMA_BD_STS_ACTUAL_LEN_MASK GENMASK(25, 0) /* Actual len */ > #define XAXIDMA_BD_STS_COMPLETE_MASK 0x80000000 /* Completed */ > #define XAXIDMA_BD_STS_DEC_ERR_MASK 0x40000000 /* Decode error */ > #define XAXIDMA_BD_STS_SLV_ERR_MASK 0x20000000 /* Slave error */ Reviewed-by: Sean Anderson