From: Gal Pressman <gal@nvidia.com>
To: Richard Gobert <richardbgobert@gmail.com>,
davem@davemloft.net, edumazet@google.com, kuba@kernel.org,
pabeni@redhat.com, willemdebruijn.kernel@gmail.com,
dsahern@kernel.org, tom@herbertland.com, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org, Nimrod Oren <noren@nvidia.com>
Subject: Re: [PATCH v2 1/1] net: gro: fix misuse of CB in udp socket lookup
Date: Sun, 23 Jul 2023 15:07:24 +0300 [thread overview]
Message-ID: <9c0a3c64-2bcb-9b82-1805-a29cb7b7e617@nvidia.com> (raw)
In-Reply-To: <20230720162624.GA16428@debian>
On 20/07/2023 19:26, Richard Gobert wrote:
> This patch fixes a misuse of IP{6}CB(skb) in GRO, while calling to
> `udp6_lib_lookup2` when handling udp tunnels. `udp6_lib_lookup2` fetch the
> device from CB. The fix changes it to fetch the device from `skb->dev`.
> l3mdev case requires special attention since it has a master and a slave
> device.
>
> Fixes: a6024562ffd7 ("udp: Add GRO functions to UDP socket")
> Reported-by: Gal Pressman <gal@nvidia.com>
> Signed-off-by: Richard Gobert <richardbgobert@gmail.com>
Thanks Richard!
Tested-by: Nimrod Oren <noren@nvidia.com>
next prev parent reply other threads:[~2023-07-23 12:07 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-20 16:13 [PATCH v2 0/1] net: gro: fix misuse of CB in udp socket lookup Richard Gobert
2023-07-20 16:26 ` [PATCH v2 1/1] " Richard Gobert
2023-07-21 9:52 ` David Laight
2023-07-23 12:07 ` Gal Pressman [this message]
2023-07-25 7:15 ` Paolo Abeni
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9c0a3c64-2bcb-9b82-1805-a29cb7b7e617@nvidia.com \
--to=gal@nvidia.com \
--cc=davem@davemloft.net \
--cc=dsahern@kernel.org \
--cc=edumazet@google.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=noren@nvidia.com \
--cc=pabeni@redhat.com \
--cc=richardbgobert@gmail.com \
--cc=tom@herbertland.com \
--cc=willemdebruijn.kernel@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).