From: Florian Fainelli <florian.fainelli@broadcom.com>
To: Andrew Lunn <andrew@lunn.ch>,
Florian Fainelli <florian.fainelli@broadcom.com>
Cc: netdev@vger.kernel.org, Doug Berger <opendmb@gmail.com>,
Broadcom internal kernel review list
<bcm-kernel-feedback-list@broadcom.com>,
Heiner Kallweit <hkallweit1@gmail.com>,
Russell King <linux@armlinux.org.uk>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
Jacob Keller <jacob.e.keller@intel.com>,
open list <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH net] net: mdio: mdio-bcm-unimac: Correct rate fallback logic
Date: Tue, 29 Jul 2025 15:22:57 -0700 [thread overview]
Message-ID: <9c10c78b-3818-4b97-8d10-bc038ec97947@broadcom.com> (raw)
In-Reply-To: <11482de4-2a37-48b5-a98e-ba8a51a355cd@lunn.ch>
On 7/29/25 15:20, Andrew Lunn wrote:
> On Tue, Jul 29, 2025 at 02:31:48PM -0700, Florian Fainelli wrote:
>> In case the rate for the parent clock is zero,
>
> Is there a legitimate reason the parent clock would be zero?
Yes there is, the parent clock might be a gated clock that aggregates
multiple sub-clocks and therefore has multiple "parents" technically.
Because it has multiple parents, we can't really return a particular
rate (clock provider is SCMI/firmware).
>
> I can understand an optional clock being missing, but it seems odd
> that a clock is available, but it is ticking at 0Hz?
>
> Maybe for this case, a warning should be issued to indicate something
> odd is going on?
>
> Andrew
>
--
Florian
next prev parent reply other threads:[~2025-07-29 22:23 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-07-29 21:31 [PATCH net] net: mdio: mdio-bcm-unimac: Correct rate fallback logic Florian Fainelli
2025-07-29 22:20 ` Andrew Lunn
2025-07-29 22:22 ` Florian Fainelli [this message]
2025-07-29 22:44 ` Andrew Lunn
2025-07-29 22:50 ` Florian Fainelli
2025-07-30 14:33 ` Simon Horman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9c10c78b-3818-4b97-8d10-bc038ec97947@broadcom.com \
--to=florian.fainelli@broadcom.com \
--cc=andrew@lunn.ch \
--cc=bcm-kernel-feedback-list@broadcom.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=hkallweit1@gmail.com \
--cc=jacob.e.keller@intel.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=netdev@vger.kernel.org \
--cc=opendmb@gmail.com \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox