From: Paolo Abeni <pabeni@redhat.com>
To: "Russell King (Oracle)" <rmk+kernel@armlinux.org.uk>,
Andrew Lunn <andrew@lunn.ch>,
Heiner Kallweit <hkallweit1@gmail.com>
Cc: Florian Fainelli <f.fainelli@gmail.com>,
Vladimir Oltean <olteanv@gmail.com>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>,
Jonathan McDowell <noodles@earth.li>,
netdev@vger.kernel.org
Subject: Re: [PATCH net-next] net: dsa: qca8k: remove assignment of an_enabled in pcs_get_state()
Date: Tue, 21 Mar 2023 12:47:08 +0100 [thread overview]
Message-ID: <9c2a6d714969b0151da4e3aaaf4fa2b7c4e9f616.camel@redhat.com> (raw)
In-Reply-To: <E1pdsE5-00Dl2l-8F@rmk-PC.armlinux.org.uk>
Hello,
On Sun, 2023-03-19 at 12:33 +0000, Russell King (Oracle) wrote:
> pcs_get_state() implementations are not supposed to alter an_enabled.
> Remove this assignment.
>
> Fixes: b3591c2a3661 ("net: dsa: qca8k: Switch to PHYLINK instead of PHYLIB")
> Signed-off-by: Russell King (Oracle) <rmk+kernel@armlinux.org.uk>
Any special reason to target the net-next tree? the fixes commit is
quite old, and this looks like a -net candidate to me?!?
Thanks!
Paolo
next prev parent reply other threads:[~2023-03-21 11:48 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-19 12:33 [PATCH net-next] net: dsa: qca8k: remove assignment of an_enabled in pcs_get_state() Russell King (Oracle)
2023-03-21 11:47 ` Paolo Abeni [this message]
2023-03-21 12:19 ` Russell King (Oracle)
2023-03-21 12:30 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9c2a6d714969b0151da4e3aaaf4fa2b7c4e9f616.camel@redhat.com \
--to=pabeni@redhat.com \
--cc=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=f.fainelli@gmail.com \
--cc=hkallweit1@gmail.com \
--cc=kuba@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=noodles@earth.li \
--cc=olteanv@gmail.com \
--cc=rmk+kernel@armlinux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).