From: Mike Galbraith <efault@gmx.de>
To: netdev <netdev@vger.kernel.org>
Cc: Realtek linux nic maintainers <nic_swsd@realtek.com>,
Heiner Kallweit <hkallweit1@gmail.com>
Subject: [patchlet] r8169: fix napi_schedule_irqoff() called with irqs enabled warning
Date: Fri, 16 Oct 2020 13:26:20 +0200 [thread overview]
Message-ID: <9c34e18280bde5c14f40b1ef89a5e6ea326dd5da.camel@gmx.de> (raw)
When the kernel is built with PREEMPT_RT or booted with threadirqs,
irqs are not disabled when rtl8169_interrupt() is called, inspiring
__raise_softirq_irqoff() to gripe. Use plain napi_schedule().
Signed-off-by: Mike Galbraith <efault@gmx.de>
---
drivers/net/ethernet/realtek/r8169_main.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
--- a/drivers/net/ethernet/realtek/r8169_main.c
+++ b/drivers/net/ethernet/realtek/r8169_main.c
@@ -4573,7 +4573,7 @@ static irqreturn_t rtl8169_interrupt(int
}
rtl_irq_disable(tp);
- napi_schedule_irqoff(&tp->napi);
+ napi_schedule(&tp->napi);
out:
rtl_ack_events(tp, status);
next reply other threads:[~2020-10-16 11:26 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-16 11:26 Mike Galbraith [this message]
2020-10-16 11:34 ` [patchlet] r8169: fix napi_schedule_irqoff() called with irqs enabled warning Heiner Kallweit
2020-10-16 11:57 ` Mike Galbraith
2020-10-16 14:26 ` Vladimir Oltean
2020-10-16 14:41 ` Heiner Kallweit
2020-10-16 15:40 ` Vladimir Oltean
2020-10-16 17:11 ` Mike Galbraith
2020-10-16 17:19 ` Vladimir Oltean
2020-10-16 19:15 ` Heiner Kallweit
2020-10-17 2:26 ` Mike Galbraith
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9c34e18280bde5c14f40b1ef89a5e6ea326dd5da.camel@gmx.de \
--to=efault@gmx.de \
--cc=hkallweit1@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=nic_swsd@realtek.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).