netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: "Hugo Santos" <hugosantos@gmail.com>
To: "Herbert Xu" <herbert@gondor.apana.org.au>
Cc: hasso@estpak.ee, yoshfuji@linux-ipv6.org, davem@davemloft.net,
	netdev@vger.kernel.org, aramoto@linux-ipv6.org,
	kozakai@linux-ipv6.org
Subject: Re: [GIT PULL] IPv6 Updates
Date: Wed, 14 Feb 2007 22:38:15 +0000	[thread overview]
Message-ID: <9c46321e0702141438l58d3eb2aoe74576d70019ea54@mail.gmail.com> (raw)
In-Reply-To: <E1HHRj7-0002HG-00@gondolin.me.apana.org.au>

  Thank you all for these changes.

  Hugo

On 2/14/07, Herbert Xu <herbert@gondor.apana.org.au> wrote:
> Herbert Xu <herbert@gondor.apana.org.au> wrote:
> >
> > [IPV4] devinet: Register inetdev earlier.
>
> I needed to move the panic call as well.
>
> [IPV4] devinet: Register inetdev earlier.
>
> This patch allocates inetdev at registration for all devices
> in line with IPv6.  This allows sysctl configuration on the
> devices to occur before they're brought up or addresses are
> added.
>
> Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
>
> Cheers,
> --
> Visit Openswan at http://www.openswan.org/
> Email: Herbert Xu ~{PmV>HI~} <herbert@gondor.apana.org.au>
> Home Page: http://gondor.apana.org.au/~herbert/
> PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
> --
> diff --git a/net/ipv4/devinet.c b/net/ipv4/devinet.c
> index ba5e7f4..2224f8e 100644
> --- a/net/ipv4/devinet.c
> +++ b/net/ipv4/devinet.c
> @@ -1055,12 +1055,14 @@ static int inetdev_event(struct notifier_block *this, unsigned long event,
>         ASSERT_RTNL();
>
>         if (!in_dev) {
> -               if (event == NETDEV_REGISTER && dev == &loopback_dev) {
> +               if (event == NETDEV_REGISTER) {
>                         in_dev = inetdev_init(dev);
> -                       if (!in_dev)
> -                               panic("devinet: Failed to create loopback\n");
> -                       in_dev->cnf.no_xfrm = 1;
> -                       in_dev->cnf.no_policy = 1;
> +                       if (dev == &loopback_dev) {
> +                               if (!in_dev)
> +                                       panic("devinet: Failed to create loopback\n");
> +                               in_dev->cnf.no_xfrm = 1;
> +                               in_dev->cnf.no_policy = 1;
> +                       }
>                 }
>                 goto out;
>         }
> -
> To unsubscribe from this list: send the line "unsubscribe netdev" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
>

  reply	other threads:[~2007-02-14 22:38 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-02-14 17:35 [GIT PULL] IPv6 Updates YOSHIFUJI Hideaki / 吉藤英明
2007-02-14 19:12 ` Vlad Yasevich
2007-02-14 19:19 ` Hasso Tepper
2007-02-14 20:57   ` Herbert Xu
2007-02-14 21:31     ` Herbert Xu
2007-02-14 22:38       ` Hugo Santos [this message]
2007-02-21  8:06       ` David Miller
2007-02-21  8:09         ` YOSHIFUJI Hideaki / 吉藤英明
2007-02-21  7:15 ` David Miller
2007-02-21  8:03   ` YOSHIFUJI Hideaki / 吉藤英明
2007-02-21  9:29     ` David Miller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=9c46321e0702141438l58d3eb2aoe74576d70019ea54@mail.gmail.com \
    --to=hugosantos@gmail.com \
    --cc=aramoto@linux-ipv6.org \
    --cc=davem@davemloft.net \
    --cc=hasso@estpak.ee \
    --cc=herbert@gondor.apana.org.au \
    --cc=kozakai@linux-ipv6.org \
    --cc=netdev@vger.kernel.org \
    --cc=yoshfuji@linux-ipv6.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).