From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.3 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,MAILING_LIST_MULTI, NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7F561C433E1 for ; Tue, 30 Mar 2021 07:01:08 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 56F6C61987 for ; Tue, 30 Mar 2021 07:01:08 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230415AbhC3HAh (ORCPT ); Tue, 30 Mar 2021 03:00:37 -0400 Received: from szxga04-in.huawei.com ([45.249.212.190]:14193 "EHLO szxga04-in.huawei.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230435AbhC3HAa (ORCPT ); Tue, 30 Mar 2021 03:00:30 -0400 Received: from DGGEMS406-HUB.china.huawei.com (unknown [172.30.72.60]) by szxga04-in.huawei.com (SkyGuard) with ESMTP id 4F8gHx72DDzmc9b; Tue, 30 Mar 2021 14:57:49 +0800 (CST) Received: from [10.67.110.73] (10.67.110.73) by DGGEMS406-HUB.china.huawei.com (10.3.19.206) with Microsoft SMTP Server id 14.3.498.0; Tue, 30 Mar 2021 15:00:18 +0800 Subject: Re: [PATCH -next] drivers: net: CONFIG_ATH9K select LEDS_CLASS To: Pavel Machek CC: "ath9k-devel@qca.qualcomm.com" , "kvalo@codeaurora.org" , "davem@davemloft.net" , "kuba@kernel.org" , "linux-wireless@vger.kernel.org" , "netdev@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "Chenyi (Johnny)" References: <20210326081351.172048-1-zhangjianhua18@huawei.com> <20210327223811.GB2875@duo.ucw.cz> From: "zhangjianhua (E)" Message-ID: <9c6989a1-614e-23af-dc90-58663aa7d9a1@huawei.com> Date: Tue, 30 Mar 2021 15:00:05 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.8.1 MIME-Version: 1.0 In-Reply-To: <20210327223811.GB2875@duo.ucw.cz> Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 8bit X-Originating-IP: [10.67.110.73] X-CFilter-Loop: Reflected Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org hello Pavel，thanks for your reply. for  the a point, I don't know the led lists and cannot find it. for the b point, I look other configs who select LEDS_CLASS, almost all of them select NEW_LEDS，maybe you are right, CONFIG_ATH9K also need select NEW_LEDS too. Best regards, Zhang Jianhua 在 2021/3/28 6:38, Pavel Machek 写道: > On Fri 2021-03-26 16:13:51, Zhang Jianhua wrote: >> If CONFIG_ATH9K=y, the following errors will be seen while compiling >> gpio.c >> >> drivers/net/wireless/ath/ath9k/gpio.o: In function `ath_deinit_leds': >> gpio.c:(.text+0x604): undefined reference to `led_classdev_unregister' >> gpio.c:(.text+0x604): relocation truncated to fit: R_AARCH64_CALL26 >> against undefined symbol `led_classdev_unregister' >> drivers/net/wireless/ath/ath9k/gpio.o: In function `ath_init_leds': >> gpio.c:(.text+0x708): undefined reference to `led_classdev_register_ext' >> gpio.c:(.text+0x708): relocation truncated to fit: R_AARCH64_CALL26 >> against undefined symbol `led_classdev_register_ext' >> >> Reported-by: Hulk Robot >> Signed-off-by: Zhang Jianhua > a) please cc led lists with led issue. > > b) probably does not work as LED_CLASS depends on NEW_LEDS...? > > Best regards, > Pavel >