* [PATCH] dt-bindings: net: mediatek,net: fixup MAC binding
@ 2023-07-29 11:10 Rafał Miłecki
2023-07-29 13:52 ` Krzysztof Kozlowski
` (2 more replies)
0 siblings, 3 replies; 4+ messages in thread
From: Rafał Miłecki @ 2023-07-29 11:10 UTC (permalink / raw)
To: David S . Miller, Eric Dumazet, Jakub Kicinski, Paolo Abeni
Cc: Rob Herring, Krzysztof Kozlowski, Conor Dooley, Matthias Brugger,
AngeloGioacchino Del Regno, Lorenzo Bianconi, Felix Fietkau,
netdev, devicetree, linux-arm-kernel, linux-mediatek,
Rafał Miłecki
From: Rafał Miłecki <rafal@milecki.pl>
1. Use unevaluatedProperties
It's needed to allow ethernet-controller.yaml properties work correctly.
2. Drop unneeded phy-handle/phy-mode
3. Don't require phy-handle
Some SoCs may use fixed link.
For in-kernel MT7621 DTS files this fixes following errors:
arch/mips/boot/dts/ralink/mt7621-tplink-hc220-g5-v1.dtb: ethernet@1e100000: mac@0: 'fixed-link' does not match any of the regexes: 'pinctrl-[0-9]+'
From schema: Documentation/devicetree/bindings/net/mediatek,net.yaml
arch/mips/boot/dts/ralink/mt7621-tplink-hc220-g5-v1.dtb: ethernet@1e100000: mac@0: 'phy-handle' is a required property
From schema: Documentation/devicetree/bindings/net/mediatek,net.yaml
arch/mips/boot/dts/ralink/mt7621-tplink-hc220-g5-v1.dtb: ethernet@1e100000: mac@1: 'fixed-link' does not match any of the regexes: 'pinctrl-[0-9]+'
From schema: Documentation/devicetree/bindings/net/mediatek,net.yaml
arch/mips/boot/dts/ralink/mt7621-tplink-hc220-g5-v1.dtb: ethernet@1e100000: mac@1: 'phy-handle' is a required property
From schema: Documentation/devicetree/bindings/net/mediatek,net.yaml
Signed-off-by: Rafał Miłecki <rafal@milecki.pl>
---
Documentation/devicetree/bindings/net/mediatek,net.yaml | 7 +------
1 file changed, 1 insertion(+), 6 deletions(-)
diff --git a/Documentation/devicetree/bindings/net/mediatek,net.yaml b/Documentation/devicetree/bindings/net/mediatek,net.yaml
index 8d3554818c37..e74502a0afe8 100644
--- a/Documentation/devicetree/bindings/net/mediatek,net.yaml
+++ b/Documentation/devicetree/bindings/net/mediatek,net.yaml
@@ -388,7 +388,7 @@ allOf:
patternProperties:
"^mac@[0-1]$":
type: object
- additionalProperties: false
+ unevaluatedProperties: false
allOf:
- $ref: ethernet-controller.yaml#
description:
@@ -400,14 +400,9 @@ patternProperties:
reg:
maxItems: 1
- phy-handle: true
-
- phy-mode: true
-
required:
- reg
- compatible
- - phy-handle
required:
- compatible
--
2.35.3
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [PATCH] dt-bindings: net: mediatek,net: fixup MAC binding
2023-07-29 11:10 [PATCH] dt-bindings: net: mediatek,net: fixup MAC binding Rafał Miłecki
@ 2023-07-29 13:52 ` Krzysztof Kozlowski
2023-07-31 8:20 ` patchwork-bot+netdevbpf
2023-07-31 10:32 ` AngeloGioacchino Del Regno
2 siblings, 0 replies; 4+ messages in thread
From: Krzysztof Kozlowski @ 2023-07-29 13:52 UTC (permalink / raw)
To: Rafał Miłecki, David S . Miller, Eric Dumazet,
Jakub Kicinski, Paolo Abeni
Cc: Rob Herring, Krzysztof Kozlowski, Conor Dooley, Matthias Brugger,
AngeloGioacchino Del Regno, Lorenzo Bianconi, Felix Fietkau,
netdev, devicetree, linux-arm-kernel, linux-mediatek,
Rafał Miłecki
On 29/07/2023 13:10, Rafał Miłecki wrote:
> From: Rafał Miłecki <rafal@milecki.pl>
>
> 1. Use unevaluatedProperties
> It's needed to allow ethernet-controller.yaml properties work correctly.
>
> 2. Drop unneeded phy-handle/phy-mode
>
Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Best regards,
Krzysztof
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] dt-bindings: net: mediatek,net: fixup MAC binding
2023-07-29 11:10 [PATCH] dt-bindings: net: mediatek,net: fixup MAC binding Rafał Miłecki
2023-07-29 13:52 ` Krzysztof Kozlowski
@ 2023-07-31 8:20 ` patchwork-bot+netdevbpf
2023-07-31 10:32 ` AngeloGioacchino Del Regno
2 siblings, 0 replies; 4+ messages in thread
From: patchwork-bot+netdevbpf @ 2023-07-31 8:20 UTC (permalink / raw)
To: =?utf-8?b?UmFmYcWCIE1pxYJlY2tpIDx6YWplYzVAZ21haWwuY29tPg==?=
Cc: davem, edumazet, kuba, pabeni, robh+dt, krzysztof.kozlowski+dt,
conor+dt, matthias.bgg, angelogioacchino.delregno, lorenzo, nbd,
netdev, devicetree, linux-arm-kernel, linux-mediatek, rafal
Hello:
This patch was applied to netdev/net.git (main)
by David S. Miller <davem@davemloft.net>:
On Sat, 29 Jul 2023 13:10:45 +0200 you wrote:
> From: Rafał Miłecki <rafal@milecki.pl>
>
> 1. Use unevaluatedProperties
> It's needed to allow ethernet-controller.yaml properties work correctly.
>
> 2. Drop unneeded phy-handle/phy-mode
>
> [...]
Here is the summary with links:
- dt-bindings: net: mediatek,net: fixup MAC binding
https://git.kernel.org/netdev/net/c/8469c7f5472f
You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] dt-bindings: net: mediatek,net: fixup MAC binding
2023-07-29 11:10 [PATCH] dt-bindings: net: mediatek,net: fixup MAC binding Rafał Miłecki
2023-07-29 13:52 ` Krzysztof Kozlowski
2023-07-31 8:20 ` patchwork-bot+netdevbpf
@ 2023-07-31 10:32 ` AngeloGioacchino Del Regno
2 siblings, 0 replies; 4+ messages in thread
From: AngeloGioacchino Del Regno @ 2023-07-31 10:32 UTC (permalink / raw)
To: Rafał Miłecki, David S . Miller, Eric Dumazet,
Jakub Kicinski, Paolo Abeni
Cc: Rob Herring, Krzysztof Kozlowski, Conor Dooley, Matthias Brugger,
Lorenzo Bianconi, Felix Fietkau, netdev, devicetree,
linux-arm-kernel, linux-mediatek, Rafał Miłecki
Il 29/07/23 13:10, Rafał Miłecki ha scritto:
> From: Rafał Miłecki <rafal@milecki.pl>
>
> 1. Use unevaluatedProperties
> It's needed to allow ethernet-controller.yaml properties work correctly.
>
> 2. Drop unneeded phy-handle/phy-mode
>
> 3. Don't require phy-handle
> Some SoCs may use fixed link.
>
> For in-kernel MT7621 DTS files this fixes following errors:
> arch/mips/boot/dts/ralink/mt7621-tplink-hc220-g5-v1.dtb: ethernet@1e100000: mac@0: 'fixed-link' does not match any of the regexes: 'pinctrl-[0-9]+'
> From schema: Documentation/devicetree/bindings/net/mediatek,net.yaml
> arch/mips/boot/dts/ralink/mt7621-tplink-hc220-g5-v1.dtb: ethernet@1e100000: mac@0: 'phy-handle' is a required property
> From schema: Documentation/devicetree/bindings/net/mediatek,net.yaml
> arch/mips/boot/dts/ralink/mt7621-tplink-hc220-g5-v1.dtb: ethernet@1e100000: mac@1: 'fixed-link' does not match any of the regexes: 'pinctrl-[0-9]+'
> From schema: Documentation/devicetree/bindings/net/mediatek,net.yaml
> arch/mips/boot/dts/ralink/mt7621-tplink-hc220-g5-v1.dtb: ethernet@1e100000: mac@1: 'phy-handle' is a required property
> From schema: Documentation/devicetree/bindings/net/mediatek,net.yaml
>
> Signed-off-by: Rafał Miłecki <rafal@milecki.pl>
Reviewed-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2023-07-31 10:32 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-07-29 11:10 [PATCH] dt-bindings: net: mediatek,net: fixup MAC binding Rafał Miłecki
2023-07-29 13:52 ` Krzysztof Kozlowski
2023-07-31 8:20 ` patchwork-bot+netdevbpf
2023-07-31 10:32 ` AngeloGioacchino Del Regno
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).