netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Cosmin Ratiu <cratiu@nvidia.com>
To: "corbet@lwn.net" <corbet@lwn.net>,
	"andrew+netdev@lunn.ch" <andrew+netdev@lunn.ch>,
	"davem@davemloft.net" <davem@davemloft.net>,
	"kuba@kernel.org" <kuba@kernel.org>,
	"horms@kernel.org" <horms@kernel.org>,
	"daniel.zahka@gmail.com" <daniel.zahka@gmail.com>,
	"edumazet@google.com" <edumazet@google.com>,
	"donald.hunter@gmail.com" <donald.hunter@gmail.com>,
	"pabeni@redhat.com" <pabeni@redhat.com>
Cc: Boris Pismenny <borisp@nvidia.com>,
	Jianbo Liu <jianbol@nvidia.com>,
	"aleksander.lobakin@intel.com" <aleksander.lobakin@intel.com>,
	"kuniyu@google.com" <kuniyu@google.com>,
	"leon@kernel.org" <leon@kernel.org>,
	"toke@redhat.com" <toke@redhat.com>,
	Rahul Rameshbabu <rrameshbabu@nvidia.com>,
	"willemb@google.com" <willemb@google.com>,
	Raed Salem <raeds@nvidia.com>,
	Dragos Tatulea <dtatulea@nvidia.com>,
	"ncardwell@google.com" <ncardwell@google.com>,
	"dsahern@kernel.org" <dsahern@kernel.org>,
	"sdf@fomichev.me" <sdf@fomichev.me>,
	Saeed Mahameed <saeedm@nvidia.com>,
	"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
	Tariq Toukan <tariqt@nvidia.com>,
	Patrisious Haddad <phaddad@nvidia.com>,
	"jacob.e.keller@intel.com" <jacob.e.keller@intel.com>
Subject: Re: [PATCH v3 18/19] net/mlx5e: Add Rx data path offload
Date: Fri, 11 Jul 2025 13:01:58 +0000	[thread overview]
Message-ID: <9cda21ef8daef64cc88f2948bff3757d06af3377.camel@nvidia.com> (raw)
In-Reply-To: <20250702171326.3265825-19-daniel.zahka@gmail.com>

On Wed, 2025-07-02 at 10:13 -0700, Daniel Zahka wrote:
> diff --git
> a/drivers/net/ethernet/mellanox/mlx5/core/en_accel/psp_rxtx.h
> b/drivers/net/ethernet/mellanox/mlx5/core/en_accel/psp_rxtx.h
> index 521b2c3620e6..e3cf34bafc24 100644
> --- a/drivers/net/ethernet/mellanox/mlx5/core/en_accel/psp_rxtx.h
> +++ b/drivers/net/ethernet/mellanox/mlx5/core/en_accel/psp_rxtx.h
> @@ -10,6 +10,11 @@
>  #include "en.h"
>  #include "en/txrx.h"
>  
> +/* Bit30: PSP marker, Bit29-23: PSP syndrome, Bit22-0: PSP obj id */
> +#define MLX5_PSP_METADATA_MARKER(metadata)  ((((metadata) >> 30) &
> 0x3) == 0x3)
> +#define MLX5_PSP_METADATA_SYNDROM(metadata) (((metadata) >> 23) &
> GENMASK(6, 0))

Nit: This should be named MLX5_PSP_METADATA_SYNDROME, with an E.

Cosmin.

  reply	other threads:[~2025-07-11 13:02 UTC|newest]

Thread overview: 52+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-07-02 17:13 [PATCH v3 00/19] add basic PSP encryption for TCP connections Daniel Zahka
2025-07-02 17:13 ` [PATCH v3 01/19] psp: add documentation Daniel Zahka
2025-07-06 14:46   ` Willem de Bruijn
2025-07-02 17:13 ` [PATCH v3 02/19] psp: base PSP device support Daniel Zahka
2025-07-06 15:31   ` Willem de Bruijn
2025-07-07 21:02     ` Jakub Kicinski
2025-07-08  1:08       ` Willem de Bruijn
2025-07-02 17:13 ` [PATCH v3 03/19] net: modify core data structures for PSP datapath support Daniel Zahka
2025-07-06 15:59   ` Willem de Bruijn
2025-07-02 17:13 ` [PATCH v3 04/19] tcp: add datapath logic for PSP with inline key exchange Daniel Zahka
2025-07-06 16:16   ` Willem de Bruijn
2025-07-07 18:12     ` Daniel Zahka
2025-07-08  1:11       ` Willem de Bruijn
2025-07-10 11:58     ` Daniel Zahka
2025-07-10 13:57       ` Willem de Bruijn
2025-07-02 17:13 ` [PATCH v3 05/19] psp: add op for rotation of device key Daniel Zahka
2025-07-06 16:17   ` Willem de Bruijn
2025-07-02 17:13 ` [PATCH v3 06/19] net: move sk_validate_xmit_skb() to net/core/dev.c Daniel Zahka
2025-07-06 16:20   ` Willem de Bruijn
2025-07-02 17:13 ` [PATCH v3 07/19] net: tcp: allow tcp_timewait_sock to validate skbs before handing to device Daniel Zahka
2025-07-06 16:23   ` Willem de Bruijn
2025-07-02 17:13 ` [PATCH v3 08/19] net: psp: add socket security association code Daniel Zahka
2025-07-06 16:47   ` Willem de Bruijn
2025-07-07 21:10     ` Jakub Kicinski
2025-07-14 15:10     ` Daniel Zahka
2025-07-07 21:20   ` Jakub Kicinski
2025-07-02 17:13 ` [PATCH v3 09/19] net: psp: update the TCP MSS to reflect PSP packet overhead Daniel Zahka
2025-07-06 16:49   ` Willem de Bruijn
2025-07-06 17:15     ` Willem de Bruijn
2025-07-02 17:13 ` [PATCH v3 10/19] psp: track generations of device key Daniel Zahka
2025-07-06 16:56   ` Willem de Bruijn
2025-07-07 21:19     ` Jakub Kicinski
2025-07-08  1:06       ` Willem de Bruijn
2025-07-02 17:13 ` [PATCH v3 11/19] net/mlx5e: Support PSP offload functionality Daniel Zahka
2025-07-11 12:54   ` Cosmin Ratiu
2025-07-11 17:41     ` Daniel Zahka
2025-07-02 17:13 ` [PATCH v3 12/19] net/mlx5e: Implement PSP operations .assoc_add and .assoc_del Daniel Zahka
2025-07-11 12:57   ` Cosmin Ratiu
2025-07-02 17:13 ` [PATCH v3 13/19] psp: provide encapsulation helper for drivers Daniel Zahka
2025-07-06 16:59   ` Willem de Bruijn
2025-07-02 17:13 ` [PATCH v3 14/19] net/mlx5e: Implement PSP Tx data path Daniel Zahka
2025-07-11 13:06   ` Cosmin Ratiu
2025-07-02 17:13 ` [PATCH v3 15/19] net/mlx5e: Add PSP steering in local NIC RX Daniel Zahka
2025-07-11 12:59   ` Cosmin Ratiu
2025-07-02 17:13 ` [PATCH v3 16/19] net/mlx5e: Configure PSP Rx flow steering rules Daniel Zahka
2025-07-02 17:13 ` [PATCH v3 17/19] psp: provide decapsulation and receive helper for drivers Daniel Zahka
2025-07-06 17:07   ` Willem de Bruijn
2025-07-02 17:13 ` [PATCH v3 18/19] net/mlx5e: Add Rx data path offload Daniel Zahka
2025-07-11 13:01   ` Cosmin Ratiu [this message]
2025-07-02 17:13 ` [PATCH v3 19/19] net/mlx5e: Implement PSP key_rotate operation Daniel Zahka
2025-07-03 13:30 ` [PATCH v3 00/19] add basic PSP encryption for TCP connections Tariq Toukan
2025-07-11 13:11   ` Cosmin Ratiu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=9cda21ef8daef64cc88f2948bff3757d06af3377.camel@nvidia.com \
    --to=cratiu@nvidia.com \
    --cc=aleksander.lobakin@intel.com \
    --cc=andrew+netdev@lunn.ch \
    --cc=borisp@nvidia.com \
    --cc=corbet@lwn.net \
    --cc=daniel.zahka@gmail.com \
    --cc=davem@davemloft.net \
    --cc=donald.hunter@gmail.com \
    --cc=dsahern@kernel.org \
    --cc=dtatulea@nvidia.com \
    --cc=edumazet@google.com \
    --cc=horms@kernel.org \
    --cc=jacob.e.keller@intel.com \
    --cc=jianbol@nvidia.com \
    --cc=kuba@kernel.org \
    --cc=kuniyu@google.com \
    --cc=leon@kernel.org \
    --cc=ncardwell@google.com \
    --cc=netdev@vger.kernel.org \
    --cc=pabeni@redhat.com \
    --cc=phaddad@nvidia.com \
    --cc=raeds@nvidia.com \
    --cc=rrameshbabu@nvidia.com \
    --cc=saeedm@nvidia.com \
    --cc=sdf@fomichev.me \
    --cc=tariqt@nvidia.com \
    --cc=toke@redhat.com \
    --cc=willemb@google.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).