From mboxrd@z Thu Jan 1 00:00:00 1970 From: David Ahern Subject: Re: [PATCH] net: allow traceroute with a specified interface in a vrf Date: Fri, 26 Oct 2018 15:23:44 -0600 Message-ID: <9ce65d62-36ad-7552-2896-e1bc493286b8@gmail.com> References: <20181026112435.12159-1-mmanning@vyatta.att-mail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit To: Mike Manning , netdev@vger.kernel.org Return-path: Received: from mail-pf1-f193.google.com ([209.85.210.193]:32921 "EHLO mail-pf1-f193.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725808AbeJ0GCZ (ORCPT ); Sat, 27 Oct 2018 02:02:25 -0400 Received: by mail-pf1-f193.google.com with SMTP id a15-v6so1154601pfn.0 for ; Fri, 26 Oct 2018 14:23:48 -0700 (PDT) In-Reply-To: <20181026112435.12159-1-mmanning@vyatta.att-mail.com> Content-Language: en-US Sender: netdev-owner@vger.kernel.org List-ID: On 10/26/18 5:24 AM, Mike Manning wrote: > Traceroute executed in a vrf succeeds if no device is given or if the > vrf is given as the device, but fails if the interface is given as the > device. This is for default UDP probes, it succeeds for TCP SYN or ICMP > ECHO probes. As the skb bound dev is the interface and the sk dev is > the vrf, sk lookup fails for ICMP_DEST_UNREACH and ICMP_TIME_EXCEEDED > messages. The solution is for the secondary dev to be passed so that > the interface is available for the device match to succeed, in the same > way as is already done for non-error cases. > > Signed-off-by: Mike Manning > --- > net/ipv4/udp.c | 4 ++-- > net/ipv6/udp.c | 2 +- > 2 files changed, 3 insertions(+), 3 deletions(-) > Reviewed-by: David Ahern