From mboxrd@z Thu Jan  1 00:00:00 1970
From: Paolo Abeni <pabeni@redhat.com>
Subject: Re: [PATCH net-next 1/2] ipv4: replace ip_hdr() with skb->data for
 optimization
Date: Tue, 05 Jun 2018 14:20:42 +0200
Message-ID: <9ce783dc628699f02c45650c942f6735e93a18c4.camel@redhat.com>
References: <1528200262-11834-1-git-send-email-laoar.shao@gmail.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Cc: netdev@vger.kernel.org, inux-kernel@vger.kernel.org
To: Yafang Shao <laoar.shao@gmail.com>, edumazet@google.com,
        davem@davemloft.net
Return-path: <netdev-owner@vger.kernel.org>
Received: from mx3-rdu2.redhat.com ([66.187.233.73]:42006 "EHLO mx1.redhat.com"
        rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP
        id S1751804AbeFEMUo (ORCPT <rfc822;netdev@vger.kernel.org>);
        Tue, 5 Jun 2018 08:20:44 -0400
In-Reply-To: <1528200262-11834-1-git-send-email-laoar.shao@gmail.com>
Sender: netdev-owner@vger.kernel.org
List-ID: <netdev.vger.kernel.org>

On Tue, 2018-06-05 at 08:04 -0400, Yafang Shao wrote:
> In ip receive path, when ip header hasn't been pulled yet, ip_hdr() and
> skb->data are pointing to the same byte.
> 
> In ip output path, when ip header is just pushed, ip_hdr() and skb->data
> are pointing to the same byte.
> 
> As ip_hdr() is more expensive than using skb->data, so replace ip_hdr()
> with skb->data in these situations for optimization.

IMHO this makes the code less readable and more error prone. Which kind
of performance improvement do you measure here?

Thanks,

Paolo