From: Andrew Lunn <andrew@lunn.ch>
To: "Russell King (Oracle)" <linux@armlinux.org.uk>
Cc: Feiyang Chen <chenfeiyang@loongson.cn>,
hkallweit1@gmail.com, peppe.cavallaro@st.com,
alexandre.torgue@foss.st.com, joabreu@synopsys.com,
chenhuacai@loongson.cn, dongbiao@loongson.cn,
loongson-kernel@lists.loongnix.cn, netdev@vger.kernel.org,
loongarch@lists.linux.dev, chris.chenfeiyang@gmail.com
Subject: Re: [PATCH v3 13/16] net: stmmac: dwmac-loongson: Add 64-bit DMA and multi-vector support
Date: Thu, 3 Aug 2023 17:42:25 +0200 [thread overview]
Message-ID: <9d13989c-fc79-404c-a88b-94e5ed7f97d0@lunn.ch> (raw)
In-Reply-To: <ZMu3wTCzffo1EgNY@shell.armlinux.org.uk>
> > +static u32 get_irq_type(struct device_node *np)
> > +{
> > + struct of_phandle_args oirq;
> > +
> > + if (np && of_irq_parse_one(np, 0, &oirq) == 0 && oirq.args_count == 2)
> > + return oirq.args[1];
> > +
> > + return IRQF_TRIGGER_RISING;
> > +}
> > +
>
> I do wish that there was some IRQ maintainer I could bounce this over to
> for them to comment on, because I don't believe that this should be
> necessary in any driver - the irq subsystem should configure the IRQ
> accordingly before the driver is probed.
I agree with you, this is very likely to be wrong.
Feiyang, please look at other drivers and copy with they do.
Andrew
next prev parent reply other threads:[~2023-08-03 15:43 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-03 11:28 [PATCH v3 00/16] stmmac: Add Loongson platform support Feiyang Chen
2023-08-03 11:28 ` [PATCH v3 01/16] net: stmmac: Pass stmmac_priv and chan in some callbacks Feiyang Chen
2023-08-03 11:28 ` [PATCH v3 02/16] net: stmmac: dwmac1000: Allow platforms to choose some register offsets Feiyang Chen
2023-08-03 11:28 ` [PATCH v3 03/16] net: stmmac: dwmac1000: Add multi-channel support Feiyang Chen
2023-08-03 11:29 ` [PATCH v3 04/16] net: stmmac: dwmac1000: Add 64-bit DMA support Feiyang Chen
2023-08-03 11:29 ` [PATCH v3 05/16] net: stmmac: dwmac1000: Add Loongson register definitions Feiyang Chen
2023-08-03 11:29 ` [PATCH v3 06/16] net: stmmac: dwmac1000: Fix channel numbers for Loongson Feiyang Chen
2023-08-03 11:29 ` [PATCH v3 07/16] net: stmmac: dwmac1000: Add multiple retries for DMA reset Feiyang Chen
2023-08-03 11:30 ` [PATCH v3 08/16] net: stmmac: dwmac1000: Allow platforms to set control value Feiyang Chen
2023-08-03 11:30 ` [PATCH v3 09/16] net: stmmac: Allow platforms to set irq_flags Feiyang Chen
2023-08-03 11:30 ` [PATCH v3 10/16] net: stmmac: Add Loongson HWIF entry Feiyang Chen
2023-08-03 11:30 ` [PATCH v3 11/16] net: stmmac: dwmac-loongson: Refactor code for loongson_dwmac_probe() Feiyang Chen
2023-08-03 11:30 ` [PATCH v3 12/16] net: stmmac: dwmac-loongson: Add LS7A support Feiyang Chen
2023-08-03 11:30 ` [PATCH v3 13/16] net: stmmac: dwmac-loongson: Add 64-bit DMA and multi-vector support Feiyang Chen
2023-08-03 14:20 ` Russell King (Oracle)
2023-08-03 15:42 ` Andrew Lunn [this message]
2023-08-03 11:30 ` [PATCH v3 14/16] net: stmmac: dwmac-loongson: Disable flow control for GMAC Feiyang Chen
2023-08-04 17:28 ` Jose Abreu
2023-08-05 6:15 ` Feiyang Chen
2023-08-04 20:38 ` Russell King (Oracle)
2023-08-05 6:15 ` Feiyang Chen
2023-08-03 11:30 ` [PATCH v3 15/16] net: stmmac: dwmac-loongson: Use single queue " Feiyang Chen
2023-08-03 11:30 ` [PATCH v3 16/16] net: stmmac: dwmac-loongson: Add GNET support Feiyang Chen
2023-08-04 17:25 ` [PATCH v3 00/16] stmmac: Add Loongson platform support Jose Abreu
2023-08-05 6:14 ` Feiyang Chen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9d13989c-fc79-404c-a88b-94e5ed7f97d0@lunn.ch \
--to=andrew@lunn.ch \
--cc=alexandre.torgue@foss.st.com \
--cc=chenfeiyang@loongson.cn \
--cc=chenhuacai@loongson.cn \
--cc=chris.chenfeiyang@gmail.com \
--cc=dongbiao@loongson.cn \
--cc=hkallweit1@gmail.com \
--cc=joabreu@synopsys.com \
--cc=linux@armlinux.org.uk \
--cc=loongarch@lists.linux.dev \
--cc=loongson-kernel@lists.loongnix.cn \
--cc=netdev@vger.kernel.org \
--cc=peppe.cavallaro@st.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).