From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.remote-ip=170.10.133.124 ARC-Seal: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; cv=none; t=1792665621; b=AjY17mV2uwTTgvzaEHyX9Hv4k1CI7qRsumJmHu/KlQcn/leAj6/wmjs0wDLLWBDrPSFB q2xfHbqT2PLjvYTe634bL6ZJ/eJD5UWt6KaAddQgAXOdjtIk0wRVXdSf3Knq6jdMYotdQ KJ3V5soQhgZ2zG0J3xZ8IZLSskYY3cAzImWl17r3svfvhZHOfgpFuCOFRG7k/2GdNiZqk QMJO/6KuVuMmP8FDMCsYFSZ7k9Hc0ar5pqRthCEX4DfMkSEVIbZ4VURxSDAXIzXVlDkfL Vskcw9TF8ttj2LyCdd+Fl1zAljQINgnv+4lKqsLtuJ4DkTwW+cv6HAN46qc3jC9tNJA== ARC-Message-Signature: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; c=relaxed/relaxed; t=1792665621; h=DMARC-Filter:DKIM-Signature:Received:X-MC-Unique: X-Mimecast-MFC-AGG-ID:Received:DKIM-Signature:X-Google-DKIM-Signature: X-Forwarded-Encrypted:X-Gm-Message-State:X-Gm-Gg:X-Received: X-Received:Received:Message-ID:Date:MIME-Version:User-Agent:Subject: To:Cc:References:Content-Language:From:In-Reply-To:Content-Type: Content-Transfer-Encoding; bh=FEKm5nQsGf/I+ugCmSSfq8QJNoZ1NYPo9Xa7ZqzEb5w=; b=fA37G7ZBJ/pGvxicHghCcZ9bOTnWAr6tWn2c5piud8vEPomSeml5ht8hAB8JehI6FSTg OluwNGXmapfM8dKAwc10cazAb5G3VzqLKzd7X8BzKJ+TKPvp6Y3PxyO90WTYOhC2j2BZR K7MsYzMxfFIgna0nlIMbRjWYzYzOELZBL9pSAOOCiunYHSRGsReimRLR0nWJ4SYIBwuQE qKNZPwUQWOsmEQvfD/QwImcM2MlyZqbofWYswW1NS/ecyEpPayw8he/Ig7EujbvR+EKsX PgdY18FEApuLUtIv3vrIubtie+3Z5GKPVuF2vJy7SLpmW9MzrE/3+x/fNZcY/6SewEQ== ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=H+aAUIH0; dkim=pass header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=google header.b=BNGnn+Hb; arc=none smtp.remote-ip=170.10.133.124 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3BB62606A31D for ; Thu, 22 Oct 2026 10:40:21 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.2 smtp.subspace.kernel.org 3BB62606A31D Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key, unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=H+aAUIH0; dkim=pass (2048-bit key, unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=google header.b=BNGnn+Hb DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1792665620; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=FEKm5nQsGf/I+ugCmSSfq8QJNoZ1NYPo9Xa7ZqzEb5w=; b=H+aAUIH0CB7c7yTA6nVQsOgOvq2yvnbZT4sOQtojIefTpq3/oXmGcPBj34wd3dqy+6L9s1 1z+SyMUET+CP2h/2KKdIKCMRDt62/9bovCIzlNcq7D8Xx5dpx/ZnxlVn3DfsKS8qsCaWa6 HwPTW/4cmawzdKlbFOVqPCghmjn5mjQ= Received: from mail-wm1-f72.google.com (mail-wm1-f72.google.com [209.85.128.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-668-5P3sSNqoNr-kN6HyHc39ZA-1; Thu, 22 Oct 2026 10:40:18 +0000 X-MC-Unique: 5P3sSNqoNr-kN6HyHc39ZA-1 X-Mimecast-MFC-AGG-ID: 5P3sSNqoNr-kN6HyHc39ZA_1792665618 Received: by mail-wm1-f72.google.com with SMTP id 5b1f17b1804b1-4a020cf06c3so9746285e9.3 for ; Thu, 22 Oct 2026 03:40:18 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=google; t=1792665617; x=1793270417; darn=vger.kernel.org; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:from:to:cc:subject:date:message-id:reply-to :content-type; bh=FEKm5nQsGf/I+ugCmSSfq8QJNoZ1NYPo9Xa7ZqzEb5w=; b=BNGnn+Hb1UNwzl0XkCj84/glT4JGR/ZvQvv3wPj85ZRPvZlQKG1qaJV0ne9W1aOLHj ZjacEcR92berX4JLAOLGBKvn8MAQEnidr4uhx68Ui8wmtxCzuefbLSd8+07go83/qaSO JiZ0Y7h5p8+pJnUnds4LwkpQ1c5jiQ13NsYT/t6/xP3OckHsEmQ0D4NrF5k3UR6qdTun G8c1D9bv9nSsquOIRzDFC0RVnB13EDwwxeZfMWgdKWTknaWJVwMeTWW3eFqJj2ZatxUT 1rmAtxZc3dAp+pv2Kj/DmC1ch1DNpA/nE3VZ8sFhFuMS+fwVFivKrkiPbnsJr9WM0Enz fsWA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1792665617; x=1793270417; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=FEKm5nQsGf/I+ugCmSSfq8QJNoZ1NYPo9Xa7ZqzEb5w=; b=GGE9jYbHrC4dD8Rzyf7h02N+BKtr6IIuKKxOwiBZe6YpT6VWDmI7ydvoNMcphqZopZ SHgrPnF9Boqt3sNv3BZUdAp/PNa7CThCT6tfFnzk3TlzXe4vUcx6rXDEGPVXWDudah+i kVkWgXOgICKOE4GZCgKwE7tBABCsfm+C9xGAMzkaM5/gaOGlw1d3VwsL+vP9logSoiCG 0F5TTR2KNexlWLmZHEwfL1mnAHchPcoAHLfbj0tMlVm6q72BG7ssJPexY0fNwKFwP0jK 1dv41tYDLvgLI8/CZRFHwaOmGKhu0qpnP01V+2kOS0TbhlqRvtjUgaxtXtdqHscs73Wr 7euA== X-Forwarded-Encrypted: i=1; AKwUvBzhgtM1qhCgAcFZdy4wbkRTBUP99NVcrOSZlbaENQ8Ml0RMdqKDGmDz9xgxfTvY42oP4/SPCLU=@vger.kernel.org X-Gm-Message-State: AFq9FYKl2mUSNgV/jVqYdsYlvkF6giq7inNQLVcd0pszaQ48xo6XtnV3 41HHwGgr+q1pfi7RtC1r8nZq28d1L6t2i8llBiyb5H3UzWAMIT3xXx0R9LxEX2oIf1Iq827Rh/U LfIQqPBcBHLaVRLYZ/p5HAQVd8p4Aq0pgT0OMbJ/VIsbS+IgI6n6qVKnwew== X-Gm-Gg: AYBFou0Mu2pVcFu41K0HW7EPP4eARpt+AmDOWEbeyHq/xpOMXtMr/P8BWqaDaW1tNtr yH6M0gZYpwl1hqkSjlzQTWzTsNIK2/MWxL6QAXOKPg/dtWoGEl2ZWE5Rkj5CFIOjByDzSny+6tX /cazvuCLDPSfOrOiriSt1hJp85dDpB0SKtLRyWsRwvSeoY2vMbMIeC4itEmNkkcKJD4bUH+1m/G fbeQxCT+OZ0VyTSL3pCiyP2sBUN++i1RVQUuKuq0evPEds8T8qAUOsyLLlOEyrRQpgqlc0hfjbU fFwrNYu2KuansBXVLQ4uZy5TlA1WRTednBo0Tz3cuzKUzdLM3Q7kW0N+FHmY/VSf9cqFTii/Fg= = X-Received: by 2002:a05:600c:5308:b0:4a2:47:b79c with SMTP id 5b1f17b1804b1-4a20047b7bemr73764665e9.32.1792665617532; Thu, 22 Oct 2026 03:40:17 -0700 (PDT) X-Received: by 2002:a05:600c:5308:b0:4a2:47:b79c with SMTP id 5b1f17b1804b1-4a20047b7bemr73764225e9.32.1792665616929; Thu, 22 Oct 2026 03:40:16 -0700 (PDT) Received: from [192.168.2.75] ([46.175.183.46]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-4a207fd494dsm17235475e9.4.2026.10.22.03.40.15 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 22 Oct 2026 03:40:16 -0700 (PDT) Message-ID: <9d167482-2cac-42eb-9fa1-c242406c493d@redhat.com> Date: Thu, 22 Oct 2026 12:40:13 +0200 X-Mailing-List: netdev@vger.kernel.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH iwl-net 1/3] ice: avoid RTNL deadlock when notifying the RDMA auxiliary driver To: "Loktionov, Aleksandr" , "netdev@vger.kernel.org" Cc: "Nguyen, Anthony L" , "Kitszel, Przemyslaw" , Andrew Lunn , "David S . Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , "Ertman, David M" , Shiraz Saleem , Leon Romanovsky , "Maziarz, Kamil" , Rafal Rogalski , "Schmidt, Michal" , "linux-rdma@vger.kernel.org" , "intel-wired-lan@lists.osuosl.org" , "linux-kernel@vger.kernel.org" , "stable@vger.kernel.org" , Sebastian Andrzej Siewior , Clark Williams , Steven Rostedt , Mateusz Palczewski , "linux-rt-devel@lists.linux.dev" References: <20261019065301.3983537-1-poros@redhat.com> <20261019065301.3983537-2-poros@redhat.com> Content-Language: en-US From: Petr Oros In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 10/21/26 1:20 PM, Loktionov, Aleksandr wrote: > > >> -----Original Message----- >> From: Petr Oros >> Sent: Monday, October 19, 2026 8:53 AM >> To: netdev@vger.kernel.org >> Cc: Oros, Petr ; Nguyen, Anthony L >> ; Kitszel, Przemyslaw >> ; Andrew Lunn ; >> David S . Miller ; Eric Dumazet >> ; Jakub Kicinski ; Paolo Abeni >> ; Ertman, David M ; Shiraz >> Saleem ; Leon Romanovsky ; >> Maziarz, Kamil ; Rafal Rogalski >> ; Loktionov, Aleksandr >> ; Schmidt, Michal ; >> linux-rdma@vger.kernel.org; intel-wired-lan@lists.osuosl.org; linux- >> kernel@vger.kernel.org; stable@vger.kernel.org; Sebastian Andrzej >> Siewior ; Clark Williams ; >> Steven Rostedt ; Mateusz Palczewski >> ; linux-rt-devel@lists.linux.dev >> Subject: [PATCH iwl-net 1/3] ice: avoid RTNL deadlock when notifying the >> RDMA auxiliary driver >> >> ice_send_event_to_aux() blocks on the auxiliary device lock, and the >> dcbnl callers reach it with the RTNL lock held. The RDMA auxiliary probe >> takes the two in the opposite order, because __driver_attach() holds the >> auxiliary device lock across ib_register_device(), which needs the RTNL >> lock: >> >> systemd-udevd state:D >> really_probe <- holds device_lock(&adev->dev) >> icrdma_probe >> irdma_ib_register_device >> ib_register_device >> setup_device >> irdma_roce_port_immutable >> ib_query_port >> irdma_query_port >> ib_get_eth_speed <- blocks on rtnl_lock() >> >> lldpad state:D >> rtnetlink_rcv_msg <- holds rtnl_lock() >> dcb_doit >> dcbnl_ieee_set >> ice_dcbnl_setets >> ice_pf_dcb_cfg >> ice_send_event_to_aux <- blocks on device_lock(&adev->dev) >> >> Everything else that needs the RTNL lock piles up behind lldpad and the >> boot never completes. The probe side cannot be changed, so use >> device_trylock() and report whether the event reached the driver. >> >> IIDC_RDMA_EVENT_BEFORE_TC_CHANGE has to arrive before the traffic >> classes change, so ice_pf_dcb_cfg() refuses the request with -EBUSY >> rather than run it behind the RDMA driver's back. The critical error and >> MTU change events are sent from the service task, which consumes their >> pending bits before sending, so those are re-armed instead. >> AFTER_TC_CHANGE keeps its fire and forget behaviour, it can be neither >> refused, the hardware has already changed, nor deferred, every lock that >> would serialise a deferred delivery against the dcbnl callers forms >> another cycle. >> >> Fixes: 348048e724a0 ("ice: Implement iidc operations") >> Cc: stable@vger.kernel.org >> Signed-off-by: Petr Oros >> --- >> drivers/net/ethernet/intel/ice/ice_dcb_lib.c | 9 ++++++++- >> drivers/net/ethernet/intel/ice/ice_idc.c | 20 ++++++++++++++++---- >> drivers/net/ethernet/intel/ice/ice_idc_int.h | 2 +- >> drivers/net/ethernet/intel/ice/ice_main.c | 16 ++++++++++++---- >> 4 files changed, 37 insertions(+), 10 deletions(-) >> >> diff --git a/drivers/net/ethernet/intel/ice/ice_dcb_lib.c >> b/drivers/net/ethernet/intel/ice/ice_dcb_lib.c >> index 0bc6dd37568792..2022b46c990cb2 100644 >> --- a/drivers/net/ethernet/intel/ice/ice_dcb_lib.c >> +++ b/drivers/net/ethernet/intel/ice/ice_dcb_lib.c >> @@ -355,8 +355,10 @@ int ice_pf_dcb_cfg(struct ice_pf *pf, struct >> ice_dcbx_cfg *new_cfg, bool locked) >> struct iidc_rdma_event *event; >> int ret = ICE_DCB_NO_HW_CHG; >> struct ice_vsi *pf_vsi; >> + bool dcb_ena; >> >> curr_cfg = &pf->hw.port_info->qos_cfg.local_dcbx_cfg; >> + dcb_ena = test_bit(ICE_FLAG_DCB_ENA, pf->flags); >> >> /* FW does not care if change happened */ >> if (!pf->hw.port_info->qos_cfg.is_sw_lldp) >> @@ -406,7 +408,12 @@ int ice_pf_dcb_cfg(struct ice_pf *pf, struct >> ice_dcbx_cfg *new_cfg, bool locked) >> } >> >> set_bit(IIDC_RDMA_EVENT_BEFORE_TC_CHANGE, event->type); >> - ice_send_event_to_aux(pf, event); >> + if (!ice_send_event_to_aux(pf, event)) { >> + assign_bit(ICE_FLAG_DCB_ENA, pf->flags, dcb_ena); >> + kfree(event); >> + ret = -EBUSY; > -EBUSY doesn't match to any ICE_DCB_* constant, are you sure you tested this case? > It looks like it will be processed like ICE_DCB_NO_HW_CHG i.e. no change needed, isn't it? The negative return takes the same path as the existing -EBUSY for the custom Tx scheduler. ice_dcbnl_setets() and setpfc() pass it to dcbnl unchanged, only ICE_DCB_NO_HW_CHG is mapped to zero. setapp() and cee_set_all() mask every error, that is pre-existing and also hides -ENOMEM and the AQ errors. I have noted this in the v2 message. > > >> + goto free_cfg; >> + } >> kfree(event); >> >> /* avoid race conditions by holding the lock while disabling and >> diff --git a/drivers/net/ethernet/intel/ice/ice_idc.c >> b/drivers/net/ethernet/intel/ice/ice_idc.c >> index 102d63c3018b1f..7fd35ce966ea65 100644 >> --- a/drivers/net/ethernet/intel/ice/ice_idc.c >> +++ b/drivers/net/ethernet/intel/ice/ice_idc.c >> @@ -34,30 +34,42 @@ ice_get_auxiliary_drv(struct iidc_rdma_core_dev_info >> *cdev) >> * ice_send_event_to_aux - send event to RDMA AUX driver >> * @pf: pointer to PF struct >> * @event: event struct > > ... > >> kfree(event); >> } >> } >> -- >> 2.56.0 >