Re: [PATCH net-next V2 1/2] net/mlx5e: RX, Drop oversized packets in non-linear mode

[Jacob Keller <jacob.e.keller@intel.com>]

On 2/2/2026 11:21 PM, Tariq Toukan wrote:
> From: Dragos Tatulea <dtatulea@nvidia.com>
> 
> Currently the driver has an inconsistent behaviour between modes when it
> comes to oversized packets that are not dropped through the physical MTU
> check in HW. This can happen for Multi Host configurations where each
> port has a different MTU.
> 
> Current behavior:
> 
> 1) Striding RQ in linear mode drops the packet in SW and counts it
>     with oversize_pkts_sw_drop.
> 
> 2) Striding RQ in non-linear mode allows it like a normal packet.
> 
> 3) Legacy RQ can't receive oversized packets by design:
>     the RX WQE uses MTU sized packet buffers.
> 
> This inconsistency is not a violation of the netdev policy [1]
> but it is better to be consistent across modes.
> 
> This patch aligns (2) with (1) and (3). One exception is added for
> LRO: don't drop the oversized packet if it is an LRO packet.
> 

The doc also says that the preference is to drop packets, so this makes 
sense.

> As now rq->hw_mtu always needs to be updated during the MTU change flow,
> drop the reset avoidance optimization from mlx5e_change_mtu().
> 
> Extract the CQE LRO segments reading into a helper function as it
> is used twice now.
> 
> [1] Documentation/networking/netdevices.rst#L205
> 
> Signed-off-by: Dragos Tatulea <dtatulea@nvidia.com>
> Signed-off-by: Tariq Toukan <tariqt@nvidia.com>
> ---
Reviewed-by: Jacob Keller <jacob.e.keller@intel.com>