From: Andrew Lunn <andrew@lunn.ch>
To: Sandeep Sondagar <sandeepsondagar@gmail.com>
Cc: netdev@vger.kernel.org, linux@armlinux.org.uk,
hkallweit1@gmail.com, davem@davemloft.net, edumazet@google.com,
kuba@kernel.org, pabeni@redhat.com, linux-kernel@vger.kernel.org
Subject: Re: [PATCH net] net: phylink: treat PSGMII as an inband capable interface
Date: Fri, 7 Aug 2026 22:16:09 +0200 [thread overview]
Message-ID: <9d558c14-ddff-44d5-bf08-a6fad351e640@lunn.ch> (raw)
In-Reply-To: <20260807194937.785825-1-sandeepsondagar@gmail.com>
On Sat, Aug 08, 2026 at 01:19:37AM +0530, Sandeep Sondagar wrote:
> PSGMII (the Qualcomm 5-port SGMII) conveys the link negotiation result
> from the PHY back to the MAC through per-channel inband SGMII words,
> exactly like SGMII and QSGMII.
>
> However, PHY_INTERFACE_MODE_PSGMII is missing from
> phylink_get_inband_type(), so phylink reports INBAND_NONE for it and
> phylink_pcs_neg_mode() falls back to PHYLINK_PCS_NEG_NONE. The PCS is
> then programmed in force mode and its control-register speed bits (which
> default to 1000base) are used, so a slower copper link - e.g. 100base-T
> - is reported as 1Gbps and cannot pass traffic.
>
> Classify PSGMII alongside SGMII and QSGMII as INBAND_CISCO_SGMII so the
> PCS negotiates inband and the resolved link speed comes from the PHY
> inband word.
>
> Signed-off-by: Sandeep Sondagar <sandeepsondagar@gmail.com>
If you are targeting net, this needs a Fixes: tag. When did this
break?
Andrew
next prev parent reply other threads:[~2026-08-07 20:16 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-08-07 19:49 [PATCH net] net: phylink: treat PSGMII as an inband capable interface Sandeep Sondagar
2026-08-07 20:16 ` Andrew Lunn [this message]
2026-08-08 1:56 ` [PATCH net v2] " Sandeep Sondagar
2026-08-08 2:09 ` Sandeep Sondagar
2026-08-08 2:11 ` Sandeep Sondagar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9d558c14-ddff-44d5-bf08-a6fad351e640@lunn.ch \
--to=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=hkallweit1@gmail.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=sandeepsondagar@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox