From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.9 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 16997C43381 for ; Thu, 21 Feb 2019 14:57:37 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id DC5C72070D for ; Thu, 21 Feb 2019 14:57:36 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="RuIfUHsN" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728011AbfBUO5f (ORCPT ); Thu, 21 Feb 2019 09:57:35 -0500 Received: from mail-pl1-f194.google.com ([209.85.214.194]:46132 "EHLO mail-pl1-f194.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725832AbfBUO5f (ORCPT ); Thu, 21 Feb 2019 09:57:35 -0500 Received: by mail-pl1-f194.google.com with SMTP id o6so14291872pls.13 for ; Thu, 21 Feb 2019 06:57:35 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=teAr2xrAmL+gxzIelehhUxictZe9edFwXaCuYi8dDhM=; b=RuIfUHsNETowmyVPNAjZtQ2NSjG5LVmMKPlBFmtuPqpsLkZNfCuVi6BpehsuNo1xX/ DNxXUzQEyocNrm3/8vAMFk0Ao/zZz4I2WkCBpRdaCRV1Fauq9Fz8eXZ/KpcU26lGpLrT AEsHjj9C2xlayvERnr3CdSd59uRwTmuQZpvZwRb7ng1feeKpB3B33KVjxXsvF8CMhRXK ciDbj2IijsDrKFTh3tSo8JZWJAPGLYuPcYH2gzbPoIZdS7yeG7rKDRVBOAavgtOX7Hoi R1S68O2CVtoZmTQv1VfOqIbP8nNFtkzK1QKUL61muoykvhbFfkOG7Yx3ZV1sazvzKm/A 4v7w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=teAr2xrAmL+gxzIelehhUxictZe9edFwXaCuYi8dDhM=; b=agnenptNUnWEiT860bz7kZFKjceqQRW7gV5B3wxXnIKt+PnZ1+k5pwy4bnGtQ8pssw CuCdTx6N8EFNdv+mA41Wnt1uu9HoSZFpZBzW871NJ+QHegQ5Dg43oPstmfdmx5zwdHKg vBP4mmLoWhiuEWn/Tc3oa0peuNxcI3Jiv4MJodFKXOgpPGSrzamKF6JMD4glvJzu1vcu hgpQcQbXlPFsjlTxDb9OjivxeY7qTcM9lgsz5Nku6P1rIlhtX6beCw+576TZ1g5ySEEm 5aBnWMihIDZ1Eq8L2xJ1CM0gAoPeZEBmt1URtLKCawNeAdhHuoAPwr1XoTA4zup58ZwR ILuw== X-Gm-Message-State: AHQUAuZFJM/hrfgiR53LV6KeDv8Wr52/e5X2J1uPmAjcfrInNnF1nYpM 1EBbmajEyCyB4na8Bo5qJLA= X-Google-Smtp-Source: AHgI3IZDBi3eK0VdQ8fPEgjcMC8JkbqO+fHjHtKUbkQgET/fStg1CcdPwiA8/0ZtGgNHRviXNL+Qmg== X-Received: by 2002:a17:902:7d92:: with SMTP id a18mr26326807plm.215.1550761054760; Thu, 21 Feb 2019 06:57:34 -0800 (PST) Received: from [172.27.227.247] ([216.129.126.118]) by smtp.googlemail.com with ESMTPSA id a15sm36518838pgd.4.2019.02.21.06.57.32 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 21 Feb 2019 06:57:33 -0800 (PST) Subject: Re: [PATCH net v2 1/2] ipv6: route: enforce RCU protection in rt6_update_exception_stamp_rt() To: Paolo Abeni , netdev@vger.kernel.org Cc: "David S. Miller" References: From: David Ahern Message-ID: <9d7a8ee2-3793-b1f0-6647-9eef70ce2dd3@gmail.com> Date: Thu, 21 Feb 2019 09:57:30 -0500 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.14; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On 2/21/19 5:19 AM, Paolo Abeni wrote: > We must access rt6_info->from under RCU read lock: move the > dereference under such lock, with proper annotation. > > v1 -> v2: > - avoid using multiple, racy, fetch operations for rt->from > > Fixes: a68886a69180 ("net/ipv6: Make from in rt6_info rcu protected") > Signed-off-by: Paolo Abeni > --- > net/ipv6/route.c | 11 ++++++----- > 1 file changed, 6 insertions(+), 5 deletions(-) > Reviewed-by: David Ahern Thanks for fixing.