From: Edward Cree <ecree.xilinx@gmail.com>
To: trix@redhat.com, davem@davemloft.net, kuba@kernel.org,
wenxu@ucloud.cn, pablo@netfilter.org, jiri@mellanox.com,
herbert@gondor.apana.org.au, paulb@mellanox.com,
john.hurley@netronome.com
Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] net: flow_offload: remove trailing semicolon in macro definition
Date: Mon, 30 Nov 2020 09:24:03 +0000 [thread overview]
Message-ID: <9d9536d9-b2ba-d3f9-5cf7-56c8dd67bb3e@gmail.com> (raw)
In-Reply-To: <20201127193727.2875003-1-trix@redhat.com>
On 27/11/2020 19:37, trix@redhat.com wrote:
> From: Tom Rix <trix@redhat.com>
>
> The macro use will already have a semicolon.
>
> Signed-off-by: Tom Rix <trix@redhat.com>
> ---
> net/core/flow_offload.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/net/core/flow_offload.c b/net/core/flow_offload.c
> index d4474c812b64..59ddfd3f3876 100644
> --- a/net/core/flow_offload.c
> +++ b/net/core/flow_offload.c
> @@ -32,7 +32,7 @@ EXPORT_SYMBOL(flow_rule_alloc);
> struct flow_dissector *__d = (__m)->dissector; \
> \
> (__out)->key = skb_flow_dissector_target(__d, __type, (__m)->key); \
> - (__out)->mask = skb_flow_dissector_target(__d, __type, (__m)->mask); \
> + (__out)->mask = skb_flow_dissector_target(__d, __type, (__m)->mask) \
> Strictly speaking shouldn't this macro have a do {} while (0)
around it anyway?
-ed
prev parent reply other threads:[~2020-11-30 9:25 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-27 19:37 [PATCH] net: flow_offload: remove trailing semicolon in macro definition trix
2020-11-30 9:24 ` Edward Cree [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9d9536d9-b2ba-d3f9-5cf7-56c8dd67bb3e@gmail.com \
--to=ecree.xilinx@gmail.com \
--cc=davem@davemloft.net \
--cc=herbert@gondor.apana.org.au \
--cc=jiri@mellanox.com \
--cc=john.hurley@netronome.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pablo@netfilter.org \
--cc=paulb@mellanox.com \
--cc=trix@redhat.com \
--cc=wenxu@ucloud.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).