From mboxrd@z Thu Jan  1 00:00:00 1970
From: David Ahern <dsahern@gmail.com>
Subject: Re: [PATCHv2 net-next 14/15] net: sch: sch_cbs: add extack support
Date: Thu, 14 Dec 2017 13:11:03 -0700
Message-ID: <9da7fcfb-0b61-d72b-f049-c325a8ce653b@gmail.com>
References: <20171214183905.23066-1-aring@mojatatu.com>
 <20171214183905.23066-15-aring@mojatatu.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
Cc: xiyou.wangcong@gmail.com, jiri@resnulli.us, davem@davemloft.net,
        netdev@vger.kernel.org, kernel@mojatatu.com,
        David Ahern <dsahern@gmail.com>
To: Alexander Aring <aring@mojatatu.com>, jhs@mojatatu.com
Return-path: <netdev-owner@vger.kernel.org>
Received: from mail-pf0-f196.google.com ([209.85.192.196]:42695 "EHLO
        mail-pf0-f196.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1752064AbdLNULF (ORCPT
        <rfc822;netdev@vger.kernel.org>); Thu, 14 Dec 2017 15:11:05 -0500
Received: by mail-pf0-f196.google.com with SMTP id d23so4407813pfe.9
        for <netdev@vger.kernel.org>; Thu, 14 Dec 2017 12:11:05 -0800 (PST)
In-Reply-To: <20171214183905.23066-15-aring@mojatatu.com>
Content-Language: en-US
Sender: netdev-owner@vger.kernel.org
List-ID: <netdev.vger.kernel.org>

On 12/14/17 11:39 AM, Alexander Aring wrote:
> diff --git a/net/sched/sch_cbs.c b/net/sched/sch_cbs.c
> index 8bf6e163d29c..6d09ffd2371e 100644
> --- a/net/sched/sch_cbs.c
> +++ b/net/sched/sch_cbs.c
> @@ -219,14 +219,17 @@ static void cbs_disable_offload(struct net_device *dev,
>  }
>  
>  static int cbs_enable_offload(struct net_device *dev, struct cbs_sched_data *q,
> -			      const struct tc_cbs_qopt *opt)
> +			      const struct tc_cbs_qopt *opt,
> +			      struct netlink_ext_ack *extack)
>  {
>  	const struct net_device_ops *ops = dev->netdev_ops;
>  	struct tc_cbs_qopt_offload cbs = { };
>  	int err;
>  
> -	if (!ops->ndo_setup_tc)
> +	if (!ops->ndo_setup_tc) {
> +		NL_SET_ERR_MSG(extack, "Specified device does support cbs offload");

does *not* support ... ?