From: Thomas Falcon <tlfalcon@linux.vnet.ibm.com>
To: David Miller <davem@davemloft.net>
Cc: netdev@vger.kernel.org, nfont@linux.vnet.ibm.com,
jallen@linux.vnet.ibm.com
Subject: Re: [PATCH 3/4 net-next] ibmvnic: Pad small packets to minimum MTU size
Date: Mon, 12 Mar 2018 10:24:53 -0500 [thread overview]
Message-ID: <9dfa5d43-820d-c208-8919-7cdd94e657e6@linux.vnet.ibm.com> (raw)
In-Reply-To: <20180311.225616.1559105614501920898.davem@davemloft.net>
On 03/11/2018 09:56 PM, David Miller wrote:
> From: Thomas Falcon <tlfalcon@linux.vnet.ibm.com>
> Date: Fri, 9 Mar 2018 13:23:56 -0600
>
>> + /* For some backing devices, mishandling of small packets
>> + * can result in a loss of connection or TX stall. Device
>> + * architects recommend that no packet should be smaller
>> + * than the minimum MTU value provided to the driver, so
>> + * pad any packets to that length
>> + */
>> + if (skb->len < netdev->min_mtu) {
>> + return skb_put_padto(skb, netdev->min_mtu);
>> + }
> Please do not use curly braces for a single statement
> basic block.
>
> Thank you.
>
Oops, sorry about that. I'll fix that and resend.
Thanks.
next prev parent reply other threads:[~2018-03-12 15:24 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-03-09 19:23 [PATCH 0/4 net-next] ibmvnic: Fix VLAN and other device errata Thomas Falcon
2018-03-09 19:23 ` [PATCH 1/4 net-next] ibmvnic: Account for VLAN tag in L2 Header descriptor Thomas Falcon
2018-03-09 19:23 ` [PATCH 2/4 net-next] ibmvnic: Account for VLAN header length in TX buffers Thomas Falcon
2018-03-09 19:23 ` [PATCH 3/4 net-next] ibmvnic: Pad small packets to minimum MTU size Thomas Falcon
2018-03-12 2:56 ` David Miller
2018-03-12 15:24 ` Thomas Falcon [this message]
2018-03-09 19:23 ` [PATCH 4/4 net-next] ibmvnic: Handle TSO backing device errata Thomas Falcon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9dfa5d43-820d-c208-8919-7cdd94e657e6@linux.vnet.ibm.com \
--to=tlfalcon@linux.vnet.ibm.com \
--cc=davem@davemloft.net \
--cc=jallen@linux.vnet.ibm.com \
--cc=netdev@vger.kernel.org \
--cc=nfont@linux.vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).