From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <netdev-owner@vger.kernel.org>
Received: from mail-pl0-f45.google.com ([209.85.160.45]:39714 "EHLO
        mail-pl0-f45.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1751719AbeCPUCQ (ORCPT
        <rfc822;netdev@vger.kernel.org>); Fri, 16 Mar 2018 16:02:16 -0400
Received: by mail-pl0-f45.google.com with SMTP id k22-v6so5698338pls.6
        for <netdev@vger.kernel.org>; Fri, 16 Mar 2018 13:02:16 -0700 (PDT)
Subject: Re: [PATCH net-next 2/2] net-tcp_bbr: set tp->snd_ssthresh to BDP
 upon STARTUP exit
To: Yousuk Seung <ysseung@google.com>,
        David Miller <davem@davemloft.net>
Cc: netdev@vger.kernel.org, Neal Cardwell <ncardwell@google.com>,
        Priyaranjan Jha <priyarjha@google.com>,
        Soheil Hassas Yeganeh <soheil@google.com>,
        Yuchung Cheng <ycheng@google.com>
References: <20180316175149.224421-1-ysseung@google.com>
From: Eric Dumazet <eric.dumazet@gmail.com>
Message-ID: <9dfdbb3e-e4a0-6e80-f4db-d653c41a4c6b@gmail.com>
Date: Fri, 16 Mar 2018 13:02:11 -0700
MIME-Version: 1.0
In-Reply-To: <20180316175149.224421-1-ysseung@google.com>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Sender: netdev-owner@vger.kernel.org
List-ID: <netdev.vger.kernel.org>



On 03/16/2018 10:51 AM, Yousuk Seung wrote:
> Set tp->snd_ssthresh to BDP upon STARTUP exit. This allows us
> to check if a BBR flow exited STARTUP and the BDP at the
> time of STARTUP exit with SCM_TIMESTAMPING_OPT_STATS. Since BBR does not
> use snd_ssthresh this fix has no impact on BBR's behavior.


Reviewed-by: Eric Dumazet <edumazet@google.com>