From mboxrd@z Thu Jan 1 00:00:00 1970 From: Eric Dumazet Subject: Re: [PATCH net-next v13 3/7] sch_cake: Add optional ACK filter Date: Mon, 21 May 2018 11:17:05 -0700 Message-ID: <9e0f206d-9800-cc0d-4ff3-da06b535d4c7@gmail.com> References: <152691970035.4083.3349902669266371765.stgit@alrua-kau> <152691985736.4083.3416150561524698541.stgit@alrua-kau> <87r2m4ykrc.fsf@toke.dk> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit To: Eric Dumazet , =?UTF-8?Q?Toke_H=c3=b8iland-J=c3=b8rgensen?= , Networking , cake@lists.bufferbloat.net, Yuchung Cheng , Neal Cardwell Return-path: Received: from mail-pl0-f66.google.com ([209.85.160.66]:40582 "EHLO mail-pl0-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751526AbeEUSRG (ORCPT ); Mon, 21 May 2018 14:17:06 -0400 Received: by mail-pl0-f66.google.com with SMTP id t12-v6so9263284plo.7 for ; Mon, 21 May 2018 11:17:06 -0700 (PDT) In-Reply-To: Content-Language: en-US Sender: netdev-owner@vger.kernel.org List-ID: On 05/21/2018 11:08 AM, Eric Dumazet wrote: > > > On 05/21/2018 10:35 AM, Toke Høiland-Jørgensen wrote: > >> Ah yes, sequence number wrapping. I was thinking I needed to deal with >> that, and then got sidetracked and forgot about it. Will fix. >> >> Other than that, do you agree that this approach to SACK and header >> handling can work? > > Unfortunately this does not handle dsack (RFC 2883, and 3708) properly, I believe. > Since I will be traveling for the next ~10 days, with possibly no Internet access, or time to review patches, please CC other Google TCP experts for the next versions. Thanks.