From mboxrd@z Thu Jan 1 00:00:00 1970 From: Davide Caratti Subject: Re: [PATCH iproute2-next] tc: flower: expose hardware offload count Date: Wed, 03 Oct 2018 18:08:11 +0200 Message-ID: <9e205b2676a409c7f586f28ce1a26aa26ae119d0.camel@redhat.com> References: <1538580590-4174-1-git-send-email-vladbu@mellanox.com> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit To: Vlad Buslov , netdev@vger.kernel.org Return-path: Received: from mx1.redhat.com ([209.132.183.28]:56628 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726811AbeJCW5N (ORCPT ); Wed, 3 Oct 2018 18:57:13 -0400 In-Reply-To: <1538580590-4174-1-git-send-email-vladbu@mellanox.com> Sender: netdev-owner@vger.kernel.org List-ID: On Wed, 2018-10-03 at 18:29 +0300, Vlad Buslov wrote: > Recently flower classifier was updated to expose count of devices that > filter is offloaded to. Add support to print this counter as 'in_hw_count'. > > Signed-off-by: Vlad Buslov > Acked-by: Jiri Pirko > --- > tc/f_flower.c | 10 +++++++++- > 1 file changed, 9 insertions(+), 1 deletion(-) > > diff --git a/tc/f_flower.c b/tc/f_flower.c > index 59e5f572c542..cbacc664d397 100644 hello Vlad! > --- a/tc/f_flower.c > +++ b/tc/f_flower.c > @@ -1585,8 +1585,16 @@ static int flower_print_opt(struct filter_util *qu, FILE *f, > if (flags & TCA_CLS_FLAGS_SKIP_SW) > print_bool(PRINT_ANY, "skip_sw", "\n skip_sw", true); > > - if (flags & TCA_CLS_FLAGS_IN_HW) > + if (flags & TCA_CLS_FLAGS_IN_HW) { > print_bool(PRINT_ANY, "in_hw", "\n in_hw", true); > + > + if (tb[TCA_FLOWER_IN_HW_COUNT]) { > + __u32 count = rta_getattr_u32(tb[TCA_FLOWER_IN_HW_COUNT]); > + > + print_uint(PRINT_ANY, "in_hw_count", > + " in_hw_count %d", count); ^^ maybe using %u in the format is better? thanks! -- davide