From: Johannes Berg <johannes@sipsolutions.net>
To: Youghandhar Chintala <youghand@codeaurora.org>
Cc: davem@davemloft.net, kuba@kernel.org,
linux-wireless@vger.kernel.org, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org, kuabhs@chromium.org,
dianders@chromium.org, briannorris@chromium.org,
pillair@codeaurora.org
Subject: Re: [PATCH 2/3] mac80211: Add support to trigger sta disconnect on hardware restart
Date: Fri, 12 Feb 2021 09:44:02 +0100 [thread overview]
Message-ID: <9e24638bdadeb4f08bcc8a130d8e0fa416d0e595.camel@sipsolutions.net> (raw)
In-Reply-To: <991c55472dd1f2be79438fbc11f2aa6d96ce5075.camel@sipsolutions.net>
On Fri, 2021-02-12 at 09:42 +0100, Johannes Berg wrote:
> On Tue, 2020-12-15 at 22:53 +0530, Youghandhar Chintala wrote:
> > The right fix would be to pull the entire data path into the host
> > +++ b/net/mac80211/ieee80211_i.h
> > @@ -748,6 +748,8 @@ struct ieee80211_if_mesh {
> > * back to wireless media and to the local net stack.
> > * @IEEE80211_SDATA_DISCONNECT_RESUME: Disconnect after resume.
> > * @IEEE80211_SDATA_IN_DRIVER: indicates interface was added to driver
> > + * @IEEE80211_SDATA_DISCONNECT_HW_RESTART: Disconnect after hardware restart
> > + * recovery
>
> How did you model this on IEEE80211_SDATA_DISCONNECT_RESUME, but than
> didn't check how that's actually used?
>
> Please change it so that the two models are the same. You really don't
> need the wiphy flag.
In fact, you could even simply
generalize IEEE80211_SDATA_DISCONNECT_RESUME
and ieee80211_resume_disconnect() to _reconfig_ instead of _resume_, and
call it from the driver just before requesting HW restart.
johannes
prev parent reply other threads:[~2021-02-12 8:45 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-15 17:23 [PATCH 2/3] mac80211: Add support to trigger sta disconnect on hardware restart Youghandhar Chintala
2020-12-15 17:40 ` Felix Fietkau
2021-01-28 8:08 ` youghand
2021-02-05 21:51 ` Abhishek Kumar
2021-02-12 8:37 ` Johannes Berg
2021-09-24 7:37 ` Youghandhar Chintala
2021-09-24 7:39 ` Johannes Berg
2021-09-24 9:13 ` Youghandhar Chintala
2021-09-24 9:20 ` Johannes Berg
2021-10-05 20:20 ` Jouni Malinen
2021-02-08 15:43 ` Guenter Roeck
2021-02-12 8:42 ` Johannes Berg
2021-02-12 8:44 ` Johannes Berg [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9e24638bdadeb4f08bcc8a130d8e0fa416d0e595.camel@sipsolutions.net \
--to=johannes@sipsolutions.net \
--cc=briannorris@chromium.org \
--cc=davem@davemloft.net \
--cc=dianders@chromium.org \
--cc=kuabhs@chromium.org \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pillair@codeaurora.org \
--cc=youghand@codeaurora.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).