From mboxrd@z Thu Jan 1 00:00:00 1970 From: Eric Dumazet Subject: Re: [PATCH net-next v4 1/3] ipv4: support sport, dport and ip_proto in RTM_GETROUTE Date: Tue, 22 May 2018 08:04:45 -0700 Message-ID: <9e2a1bc7-e80a-1642-3b83-2341fddc6097@gmail.com> References: <1527000668-25253-1-git-send-email-roopa@cumulusnetworks.com> <1527000668-25253-2-git-send-email-roopa@cumulusnetworks.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Cc: netdev@vger.kernel.org, nikolay@cumulusnetworks.com, dsa@cumulusnetworks.com, idosch@mellanox.com To: Roopa Prabhu , davem@davemloft.net Return-path: Received: from mail-pl0-f66.google.com ([209.85.160.66]:36533 "EHLO mail-pl0-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751199AbeEVPEr (ORCPT ); Tue, 22 May 2018 11:04:47 -0400 Received: by mail-pl0-f66.google.com with SMTP id v24-v6so11079585plo.3 for ; Tue, 22 May 2018 08:04:47 -0700 (PDT) In-Reply-To: <1527000668-25253-2-git-send-email-roopa@cumulusnetworks.com> Content-Language: en-US Sender: netdev-owner@vger.kernel.org List-ID: On 05/22/2018 07:51 AM, Roopa Prabhu wrote: > From: Roopa Prabhu > > ... > diff --git a/net/ipv4/fib_frontend.c b/net/ipv4/fib_frontend.c > index 4d622112..cf5cfc5 100644 > --- a/net/ipv4/fib_frontend.c > +++ b/net/ipv4/fib_frontend.c > @@ -649,6 +649,10 @@ const struct nla_policy rtm_ipv4_policy[RTA_MAX + 1] = { > [RTA_ENCAP] = { .type = NLA_NESTED }, > [RTA_UID] = { .type = NLA_U32 }, > [RTA_MARK] = { .type = NLA_U32 }, > + [RTA_TABLE] = { .type = NLA_U32 }, > + [RTA_IP_PROTO] = { .type = NLA_U8 }, > + [RTA_SPORT] = { .type = NLA_U16 }, > + [RTA_DPORT] = { .type = NLA_U16 }, > }; Hi Roopa RTA_TABLE addition looks like a bug fix for net tree ? This should be sent as an independent patch IMO. Thanks.